Page MenuHomeFreeBSD

Use default shell assignment rather more complicated if then construct.
ClosedPublic

Authored by imp on Apr 2 2019, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 16 2024, 11:55 AM
Unknown Object (File)
Jan 13 2024, 11:16 AM
Unknown Object (File)
Dec 23 2023, 2:45 AM
Unknown Object (File)
Nov 26 2023, 7:29 AM
Unknown Object (File)
Sep 16 2023, 6:18 PM
Unknown Object (File)
Sep 16 2023, 4:32 PM
Unknown Object (File)
Jul 6 2023, 2:36 AM
Unknown Object (File)
Jun 29 2023, 12:18 AM
Subscribers

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23471
Build 22482: arc lint + arc unit

Event Timeline

emaste added inline comments.
sys/conf/newvers.sh
49

108


but this line looks too long?

145

eww

allanjude added inline comments.
sys/conf/newvers.sh
145

This is a pretty common shell construct, I think it is fine.

sys/conf/newvers.sh
108

Other lines are longer.

sys/conf/newvers.sh
108

Still better to not introduce new >80 col lines though... there are three > 80 cols right now, all of which are awkward to wrap to 80.

145

Agreed, it's fine, I just don't like it :)

Fix line length, per ed.

also move b= to place closer to where it's used.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2019, 6:40 PM
This revision was automatically updated to reflect the committed changes.