Differential D19604

iflib: hold the CTX lock in iflib_pseudo_register
ClosedPublic
Actions

Authored by jacob.e.keller_intel.com on Mar 15 2019, 11:53 PM.

Details

Reviewers

shurd
erj

Group Reviewers

iflib

Commits

rS345657: iflib: hold the CTX lock in iflib_pseudo_register

Summary

The iflib_device_register function takes the CTX lock before calling
IFDI_ATTACH_PRE, and releases it upon finishing the registration.

Mirror this process in iflib_pseudo_register, so that we always hold the
CTX lock during the attach process when registering a pseudo interface
or a regular interface.

This was caught by code inspection while attempting to analyze where the
CTX lock was held.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 23126
Build 22179: arc lint + arc unit

Event Timeline

jacob.e.keller_intel.com created this revision.Mar 15 2019, 11:53 PM

Herald added a reviewer: shurd. · View Herald TranscriptMar 15 2019, 11:53 PM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added a subscriber: ae. · View Herald Transcript

Harbormaster completed remote builds in B23126: Diff 55129.Mar 15 2019, 11:53 PM

Anyone else have any feedback? It makes sense to me that the attach process for pseudo devices should use the context lock like the attach process for regular devices.

Looks good to me.

This revision is now accepted and ready to land.Mar 27 2019, 5:31 PM

Closed by commit rS345657: iflib: hold the CTX lock in iflib_pseudo_register (authored by erj). · Explain WhyMar 28 2019, 8:43 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMar 28 2019, 8:44 PM