Details
Details
- Reviewers
- None
- Group Reviewers
Python O5: Ports Framework (Owns No Changed Paths) portmgr - Commits
- rP499257: Mk/Uses/python.mk: Flag unknown USES=python args and unknown USE_PYTHON features
Ran make -V DEV_ERROR over the tree. The following ports currently have problems:
# Port unknown features databases/py-asyncpg setuptools graphics/py-cairocffi cffi graphics/sk1 noflavor science/dvc noflavor
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 23060 Build 22128: arc lint + arc unit
Event Timeline
Comment Actions
All the USES that validate their arguments set IGNORE so that the mistake is found out early. I think this should also be setting IGNORE. Also, could you check that the arguments to USES=python:xxx are also validated?
Comment Actions
- Check USES=python arguments too
New failures:
# Port bogus args games/ski 3.2+:run net-mgmt/librenms-agent 2.7:run sysutils/py-python-consul 2.7-3.6+ sysutils/xen-guest-tools configure
Comment Actions
Mmmm, nice, I "fixed" all four.
I don't see anything wrong with the code, I'll let the other portmgr ponder this for a bit.
| Mk/Uses/python.mk | ||
|---|---|---|
| 254–258 | I would suggest merging _PYTHON_FEATURE_<FEATURENAME> setting (line 263-266) as follows: .for var in ${USE_PYTHON}
. if !empty(_VALID_PYTHON_FEATURES:M${var})
_PYTHON_FEATURE_${var:C/=.*$//:tu}= ${var:C/.*=//:S/,/ /g}
. else
_INVALID_PYTHON_FEATURES+= ${var}
. endif
.endfor | |
| Mk/Uses/python.mk | ||
|---|---|---|
| 254–258 | Why? What is wrong with looping twice? | |
| Mk/Uses/python.mk | ||
|---|---|---|
| 254–258 | I'm not saying it's wrong. It's just a suggestion. | |
Comment Actions
Thanks. Committed in rP499257. I probably should have reclaimed this before committing for Phabricator to update this post-commit.