Mk/Uses/python.mk: Flag unknown USE_PYTHON features

[tobik]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235901

Test Plan

Ran make -V DEV_ERROR over the tree. The following ports currently have problems:

# Port				unknown features
databases/py-asyncpg		setuptools
graphics/py-cairocffi		cffi
graphics/sk1			noflavor
science/dvc			noflavor

[mat]

All the USES that validate their arguments set IGNORE so that the mistake is found out early. I think this should also be setting IGNORE. Also, could you check that the arguments to USES=python:xxx are also validated?

[tobik]

• Use IGNORE instead

[tobik]

• Check USES=python arguments too

New failures:

# Port				bogus args
games/ski			3.2+:run
net-mgmt/librenms-agent		2.7:run
sysutils/py-python-consul	2.7-3.6+
sysutils/xen-guest-tools	configure

[tobik]

• Simplify and use :N instead of :C

[mat]

In D19569#418889, @tobik wrote:

# Port				bogus args
games/ski			3.2+:run
net-mgmt/librenms-agent		2.7:run
sysutils/py-python-consul	2.7-3.6+
sysutils/xen-guest-tools	configure

Mmmm, nice, I "fixed" all four.

I don't see anything wrong with the code, I'll let the other portmgr ponder this for a bit.

[sunpoet]

Mk/Uses/python.mk

254–258

I would suggest merging _PYTHON_FEATURE_<FEATURENAME> setting (line 263-266) as follows:

.for var in ${USE_PYTHON}
.  if !empty(_VALID_PYTHON_FEATURES:M${var})
_PYTHON_FEATURE_${var:C/=.*$//:tu}=        ${var:C/.*=//:S/,/ /g}
.  else
_INVALID_PYTHON_FEATURES+=        ${var}
.  endif
.endfor

[tobik]

Mk/Uses/python.mk

254–258

Why? What is wrong with looping twice?

[sunpoet]

Mk/Uses/python.mk

254–258

I'm not saying it's wrong. It's just a suggestion.

[mat]

Please, do commit this.

[tobik]

Thanks. Committed in rP499257. I probably should have reclaimed this before committing for Phabricator to update this post-commit.