Page MenuHomeFreeBSD
Differential D19555

camcontrol.8: Bump date after r345051
ClosedPublic
Actions

Authored by 0mp on Mar 12 2019, 9:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 2:30 PM
Unknown Object (File)
Feb 10 2025, 11:59 AM
Unknown Object (File)
Feb 3 2025, 12:40 AM
Unknown Object (File)
Jan 10 2025, 3:24 AM
Unknown Object (File)
Nov 25 2024, 12:18 AM
Unknown Object (File)
Oct 9 2024, 6:38 PM
Unknown Object (File)
Oct 4 2024, 5:52 AM
Unknown Object (File)
Oct 4 2024, 4:25 AM
View All 57 Files
Subscribers
None

Details

Reviewers
bcr
imp
Group Reviewers
manpages
Commits
rS345060: camcontrol.8: Bump date after r345051
Summary
camcontrol.8: Bump date after r345051

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 23029
Build 22100: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sbin/
camcontrol/
2 lines

Diff 54963

View Options

sbin/camcontrol/camcontrol.8

Show First 20 Lines • Show All 211 Lines • ▼ Show 20 Lines if ((frame->tf_scause == EXCP_FAULT_STORE) ||
ftype = VM_PROT_EXECUTE; ftype = VM_PROT_EXECUTE;
} else { } else {
ftype = VM_PROT_READ; ftype = VM_PROT_READ;
} }
if (pmap_fault_fixup(map->pmap, va, ftype)) if (pmap_fault_fixup(map->pmap, va, ftype))
goto done; goto done;
if (map != kernel_map) { error = vm_fault_trap(map, va, ftype, VM_FAULT_NORMAL, &sig, &ucode);
/*
* Keep swapout from messing with us during this
* critical time.
*/
PROC_LOCK(p);
++p->p_lock;
PROC_UNLOCK(p);
/* Fault in the user page: */
error = vm_fault(map, va, ftype, VM_FAULT_NORMAL);
PROC_LOCK(p);
--p->p_lock;
PROC_UNLOCK(p);
} else {
/*
* Don't have to worry about process locking or stacks in the
* kernel.
*/
error = vm_fault(map, va, ftype, VM_FAULT_NORMAL);
}
alcUnsubmitted
Done
Inline Actions

I'm surprised to see this snippet brought back to life in the riscv code. We removed it from elsewhere in the source tree almost exactly 4 years ago (r287625).

I would suggest committing the removal of this snippet now, and thus separately from the rest.

alc: I'm surprised to see this snippet brought back to life in the riscv code. We removed it from…
if (error != KERN_SUCCESS) { if (error != KERN_SUCCESS) {
if (usermode) { if (usermode) {
sig = SIGSEGV;
if (error == KERN_PROTECTION_FAILURE)
ucode = SEGV_ACCERR;
else
ucode = SEGV_MAPERR;
call_trapsignal(td, sig, ucode, (void *)stval); call_trapsignal(td, sig, ucode, (void *)stval);
} else { } else {
if (pcb->pcb_onfault != 0) { if (pcb->pcb_onfault != 0) {
frame->tf_a[0] = error; frame->tf_a[0] = error;
frame->tf_sepc = pcb->pcb_onfault; frame->tf_sepc = pcb->pcb_onfault;
return; return;
} }
goto fatal; goto fatal;
▲ Show 20 Lines • Show All 139 Lines • Show Last 20 Lines