Page MenuHomeFreeBSD
Differential D19258

import linux debugfs support
ClosedPublic
Actions

Authored by mmacy on Feb 19 2019, 10:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 6, 8:11 PM
Unknown Object (File)
Mon, Feb 24, 3:36 AM
Unknown Object (File)
Sat, Feb 22, 2:36 PM
Unknown Object (File)
Sat, Feb 22, 6:18 AM
Unknown Object (File)
Sat, Feb 22, 3:31 AM
Unknown Object (File)
Feb 17 2025, 9:50 PM
Unknown Object (File)
Jan 21 2025, 5:29 AM
Unknown Object (File)
Jan 20 2025, 9:19 PM
View All 93 Files
Subscribers
emaste
imp
kmoore

Details

Reviewers
• hselasky
Commits
rS348273: MFC r344485:
rS344485: import linux debugfs support
Summary
  • gcov support relies on debugfs

pull in debugfs and seq file support

depends on D19256 and D19257

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mmacy created this revision.Feb 19 2019, 10:49 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 19 2019, 10:49 PM
Harbormaster completed remote builds in B22589: Diff 54099.Feb 19 2019, 10:49 PM
mmacy edited the summary of this revision. (Show Details)Feb 19 2019, 10:55 PM
mmacy added parent revisions: D19257: allow late binding of linux_alloc_current, D19256: PFS: Bump NAMELEN and don't require clients to be sleepable.
• hselasky added inline comments.Feb 20 2019, 8:07 AM
sys/compat/lindebugfs/lindebugfs.c
140 ↗(On Diff #54099)

Print is missing: %s:%d FUNCTION, LINE

157 ↗(On Diff #54099)

ditto

mmacy updated this revision to Diff 54154.Feb 20 2019, 9:31 PM
  • incorporate feedback printing file/line on failure
Harbormaster completed remote builds in B22628: Diff 54154.Feb 20 2019, 9:31 PM
• hselasky accepted this revision.Feb 20 2019, 9:37 PM

Looks good.

This revision is now accepted and ready to land.Feb 20 2019, 9:37 PM
Closed by commit rS344485: import linux debugfs support (authored by mmacy). · Explain WhyFeb 23 2019, 8:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
lindebugfs/
309 lines
linuxkpi/
common/
include/
linux/
51 lines
71 lines
src/
157 lines

Diff 54269

View Options

head/sys/compat/lindebugfs/lindebugfs.c

Show First 20 Lines • Show All 136 Lines • ▼ Show 20 Linessetup(void)
if (in.name == NULL) { if (in.name == NULL) {
in.name = "stdin"; in.name = "stdin";
in.fd = STDIN_FILENO; in.fd = STDIN_FILENO;
} else { } else {
in.fd = open(in.name, O_RDONLY, 0); in.fd = open(in.name, O_RDONLY, 0);
if (in.fd == -1) if (in.fd == -1)
err(1, "%s", in.name); err(1, "%s", in.name);
if (caph_limit_stdin() == -1)
err(1, "unable to limit capability rights");
} }
getfdtype(&in); getfdtype(&in);
cap_rights_init(&rights, CAP_READ, CAP_SEEK); cap_rights_init(&rights, CAP_READ, CAP_SEEK);
if (cap_rights_limit(in.fd, &rights) == -1 && errno != ENOSYS) if (cap_rights_limit(in.fd, &rights) == -1 && errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
Show All 16 Lines#define OFLAGS \
*/ */
if (out.fd == -1) { if (out.fd == -1) {
out.fd = open(out.name, O_WRONLY | OFLAGS, DEFFILEMODE); out.fd = open(out.name, O_WRONLY | OFLAGS, DEFFILEMODE);
out.flags |= NOREAD; out.flags |= NOREAD;
cap_rights_clear(&rights, CAP_READ); cap_rights_clear(&rights, CAP_READ);
} }
if (out.fd == -1) if (out.fd == -1)
err(1, "%s", out.name); err(1, "%s", out.name);
if (caph_limit_stdout() == -1)
err(1, "unable to limit capability rights");
} }
getfdtype(&out); getfdtype(&out);
if (cap_rights_limit(out.fd, &rights) == -1 && errno != ENOSYS) if (cap_rights_limit(out.fd, &rights) == -1 && errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
if (cap_ioctls_limit(out.fd, cmds, nitems(cmds)) == -1 && if (cap_ioctls_limit(out.fd, cmds, nitems(cmds)) == -1 &&
errno != ENOSYS) errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
if (in.fd != STDIN_FILENO && out.fd != STDIN_FILENO) {
if (caph_limit_stdin() == -1)
err(1, "unable to limit capability rights");
}
if (in.fd != STDOUT_FILENO && out.fd != STDOUT_FILENO) {
if (caph_limit_stdout() == -1)
err(1, "unable to limit capability rights");
}
if (in.fd != STDERR_FILENO && out.fd != STDERR_FILENO) { if (in.fd != STDERR_FILENO && out.fd != STDERR_FILENO) {
if (caph_limit_stderr() == -1) if (caph_limit_stderr() == -1)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
} }
/* /*
* Allocate space for the input and output buffers. If not doing * Allocate space for the input and output buffers. If not doing
▲ Show 20 Lines • Show All 389 Lines • Show Last 20 Lines
View Options

head/sys/compat/linuxkpi/common/include/linux/debugfs.h

Show First 20 Lines • Show All 136 Lines • ▼ Show 20 Linessetup(void)
if (in.name == NULL) { if (in.name == NULL) {
in.name = "stdin"; in.name = "stdin";
in.fd = STDIN_FILENO; in.fd = STDIN_FILENO;
} else { } else {
in.fd = open(in.name, O_RDONLY, 0); in.fd = open(in.name, O_RDONLY, 0);
if (in.fd == -1) if (in.fd == -1)
err(1, "%s", in.name); err(1, "%s", in.name);
if (caph_limit_stdin() == -1)
err(1, "unable to limit capability rights");
} }
getfdtype(&in); getfdtype(&in);
cap_rights_init(&rights, CAP_READ, CAP_SEEK); cap_rights_init(&rights, CAP_READ, CAP_SEEK);
if (cap_rights_limit(in.fd, &rights) == -1 && errno != ENOSYS) if (cap_rights_limit(in.fd, &rights) == -1 && errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
Show All 16 Lines#define OFLAGS \
*/ */
if (out.fd == -1) { if (out.fd == -1) {
out.fd = open(out.name, O_WRONLY | OFLAGS, DEFFILEMODE); out.fd = open(out.name, O_WRONLY | OFLAGS, DEFFILEMODE);
out.flags |= NOREAD; out.flags |= NOREAD;
cap_rights_clear(&rights, CAP_READ); cap_rights_clear(&rights, CAP_READ);
} }
if (out.fd == -1) if (out.fd == -1)
err(1, "%s", out.name); err(1, "%s", out.name);
if (caph_limit_stdout() == -1)
err(1, "unable to limit capability rights");
} }
getfdtype(&out); getfdtype(&out);
if (cap_rights_limit(out.fd, &rights) == -1 && errno != ENOSYS) if (cap_rights_limit(out.fd, &rights) == -1 && errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
if (cap_ioctls_limit(out.fd, cmds, nitems(cmds)) == -1 && if (cap_ioctls_limit(out.fd, cmds, nitems(cmds)) == -1 &&
errno != ENOSYS) errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
if (in.fd != STDIN_FILENO && out.fd != STDIN_FILENO) {
if (caph_limit_stdin() == -1)
err(1, "unable to limit capability rights");
}
if (in.fd != STDOUT_FILENO && out.fd != STDOUT_FILENO) {
if (caph_limit_stdout() == -1)
err(1, "unable to limit capability rights");
}
if (in.fd != STDERR_FILENO && out.fd != STDERR_FILENO) { if (in.fd != STDERR_FILENO && out.fd != STDERR_FILENO) {
if (caph_limit_stderr() == -1) if (caph_limit_stderr() == -1)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
} }
/* /*
* Allocate space for the input and output buffers. If not doing * Allocate space for the input and output buffers. If not doing
▲ Show 20 Lines • Show All 389 Lines • Show Last 20 Lines
View Options

head/sys/compat/linuxkpi/common/include/linux/seq_file.h

Show First 20 Lines • Show All 136 Lines • ▼ Show 20 Linessetup(void)
if (in.name == NULL) { if (in.name == NULL) {
in.name = "stdin"; in.name = "stdin";
in.fd = STDIN_FILENO; in.fd = STDIN_FILENO;
} else { } else {
in.fd = open(in.name, O_RDONLY, 0); in.fd = open(in.name, O_RDONLY, 0);
if (in.fd == -1) if (in.fd == -1)
err(1, "%s", in.name); err(1, "%s", in.name);
if (caph_limit_stdin() == -1)
err(1, "unable to limit capability rights");
} }
getfdtype(&in); getfdtype(&in);
cap_rights_init(&rights, CAP_READ, CAP_SEEK); cap_rights_init(&rights, CAP_READ, CAP_SEEK);
if (cap_rights_limit(in.fd, &rights) == -1 && errno != ENOSYS) if (cap_rights_limit(in.fd, &rights) == -1 && errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
Show All 16 Lines#define OFLAGS \
*/ */
if (out.fd == -1) { if (out.fd == -1) {
out.fd = open(out.name, O_WRONLY | OFLAGS, DEFFILEMODE); out.fd = open(out.name, O_WRONLY | OFLAGS, DEFFILEMODE);
out.flags |= NOREAD; out.flags |= NOREAD;
cap_rights_clear(&rights, CAP_READ); cap_rights_clear(&rights, CAP_READ);
} }
if (out.fd == -1) if (out.fd == -1)
err(1, "%s", out.name); err(1, "%s", out.name);
if (caph_limit_stdout() == -1)
err(1, "unable to limit capability rights");
} }
getfdtype(&out); getfdtype(&out);
if (cap_rights_limit(out.fd, &rights) == -1 && errno != ENOSYS) if (cap_rights_limit(out.fd, &rights) == -1 && errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
if (cap_ioctls_limit(out.fd, cmds, nitems(cmds)) == -1 && if (cap_ioctls_limit(out.fd, cmds, nitems(cmds)) == -1 &&
errno != ENOSYS) errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
if (in.fd != STDIN_FILENO && out.fd != STDIN_FILENO) {
if (caph_limit_stdin() == -1)
err(1, "unable to limit capability rights");
}
if (in.fd != STDOUT_FILENO && out.fd != STDOUT_FILENO) {
if (caph_limit_stdout() == -1)
err(1, "unable to limit capability rights");
}
if (in.fd != STDERR_FILENO && out.fd != STDERR_FILENO) { if (in.fd != STDERR_FILENO && out.fd != STDERR_FILENO) {
if (caph_limit_stderr() == -1) if (caph_limit_stderr() == -1)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
} }
/* /*
* Allocate space for the input and output buffers. If not doing * Allocate space for the input and output buffers. If not doing
▲ Show 20 Lines • Show All 389 Lines • Show Last 20 Lines
View Options

head/sys/compat/linuxkpi/common/src/linux_seq_file.c

Show First 20 Lines • Show All 136 Lines • ▼ Show 20 Linessetup(void)
if (in.name == NULL) { if (in.name == NULL) {
in.name = "stdin"; in.name = "stdin";
in.fd = STDIN_FILENO; in.fd = STDIN_FILENO;
} else { } else {
in.fd = open(in.name, O_RDONLY, 0); in.fd = open(in.name, O_RDONLY, 0);
if (in.fd == -1) if (in.fd == -1)
err(1, "%s", in.name); err(1, "%s", in.name);
if (caph_limit_stdin() == -1)
err(1, "unable to limit capability rights");
} }
getfdtype(&in); getfdtype(&in);
cap_rights_init(&rights, CAP_READ, CAP_SEEK); cap_rights_init(&rights, CAP_READ, CAP_SEEK);
if (cap_rights_limit(in.fd, &rights) == -1 && errno != ENOSYS) if (cap_rights_limit(in.fd, &rights) == -1 && errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
Show All 16 Lines#define OFLAGS \
*/ */
if (out.fd == -1) { if (out.fd == -1) {
out.fd = open(out.name, O_WRONLY | OFLAGS, DEFFILEMODE); out.fd = open(out.name, O_WRONLY | OFLAGS, DEFFILEMODE);
out.flags |= NOREAD; out.flags |= NOREAD;
cap_rights_clear(&rights, CAP_READ); cap_rights_clear(&rights, CAP_READ);
} }
if (out.fd == -1) if (out.fd == -1)
err(1, "%s", out.name); err(1, "%s", out.name);
if (caph_limit_stdout() == -1)
err(1, "unable to limit capability rights");
} }
getfdtype(&out); getfdtype(&out);
if (cap_rights_limit(out.fd, &rights) == -1 && errno != ENOSYS) if (cap_rights_limit(out.fd, &rights) == -1 && errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
if (cap_ioctls_limit(out.fd, cmds, nitems(cmds)) == -1 && if (cap_ioctls_limit(out.fd, cmds, nitems(cmds)) == -1 &&
errno != ENOSYS) errno != ENOSYS)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
if (in.fd != STDIN_FILENO && out.fd != STDIN_FILENO) {
if (caph_limit_stdin() == -1)
err(1, "unable to limit capability rights");
}
if (in.fd != STDOUT_FILENO && out.fd != STDOUT_FILENO) {
if (caph_limit_stdout() == -1)
err(1, "unable to limit capability rights");
}
if (in.fd != STDERR_FILENO && out.fd != STDERR_FILENO) { if (in.fd != STDERR_FILENO && out.fd != STDERR_FILENO) {
if (caph_limit_stderr() == -1) if (caph_limit_stderr() == -1)
err(1, "unable to limit capability rights"); err(1, "unable to limit capability rights");
} }
/* /*
* Allocate space for the input and output buffers. If not doing * Allocate space for the input and output buffers. If not doing
▲ Show 20 Lines • Show All 389 Lines • Show Last 20 Lines