Differential D19276

Support struct ip_mreqn in IP_ADD_MEMBERSHIP.
ClosedPublic
Actions

Authored by glebius on Feb 20 2019, 10:55 PM.

Details

Reviewers

None

Group Reviewers

network
manpages

Commits

rS344481: Support struct ip_mreqn as argument for IP_ADD_MEMBERSHIP. Legacy support

Summary

struct ip_mreqn is Linux extension to classic BSD multicast API. It
has extra fields allowing to specify the interface index explicitly.

We have it declared since r170613 and IP_MULTICAST_IF supports it.

In Linux the structure is used both for IP_MULTICAST_IF and for
IP_ADD_MEMBERSHIP.

The problem is that thirdy party programs see structure declaration
and assume that system supports ip_mreqn for IP_ADD_MEMBERSHIP.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22632
Build 21741: arc lint + arc unit

Event Timeline

glebius created this revision.Feb 20 2019, 10:55 PM

Herald added a reviewer: manpages. · View Herald TranscriptFeb 20 2019, 10:55 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B22632: Diff 54166.Feb 20 2019, 10:56 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 23 2019, 6:03 AM

Closed by commit rS344481: Support struct ip_mreqn as argument for IP_ADD_MEMBERSHIP. Legacy support (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

ip.4

55 lines

sys/

netinet/

in_mcast.c

57 lines

Diff 54166

View Options

share/man/man4/ip.4