Differential D19257

allow late binding of linux_alloc_current
ClosedPublic
Actions

Authored by mmacy on Feb 19 2019, 10:47 PM.

Tags

None

Referenced Files

	F168083076: D19257.id.diff
	Wed, Aug 26, 7:23 AM

	F168065780: D19257.diff
	Wed, Aug 26, 5:25 AM

	Unknown Object (File)
	Mon, Aug 24, 7:15 PM

	Unknown Object (File)
	Mon, Aug 24, 7:09 PM

	Unknown Object (File)
	Sun, Aug 23, 8:05 PM

	Unknown Object (File)
	Sun, Aug 23, 8:54 AM

	Unknown Object (File)
	Sat, Aug 22, 9:26 PM

	Unknown Object (File)
	Sat, Aug 22, 6:40 PM

Subscribers

Details

Reviewers

Commits

rS344478: lkpi: allow late binding of linux_alloc_current

Summary

lindebugfs may be used independently of the lkpi. This allows it to call linux_alloc_current without having a static dependency.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 22588

Event Timeline

mmacy created this revision.Feb 19 2019, 10:47 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 19 2019, 10:47 PM

Harbormaster completed remote builds in B22588: Diff 54098.Feb 19 2019, 10:47 PM

mmacy added a child revision: D19258: import linux debugfs support.Feb 19 2019, 10:55 PM

• hselasky added inline comments.Feb 20 2019, 7:59 AM

sys/compat/linuxkpi/common/src/linux_current.c
223	The alloc_current pointer should be set before registering the eventhandler.
246	the alloc_current pointer should be cleared after deregistering the eventhandler.
sys/kern/init_main.c
109	Is the header file for this prototype included?

• hselasky added inline comments.Feb 20 2019, 8:02 AM

sys/compat/linuxkpi/common/include/linux/compat.h
49	For sake of optimisation I want you to always set the lkpi_alloc_current pointer. I.E. In main make a lkpi_default_alloc_current() function, which is used to initialize the pointer and does nothing.

incorporate feedback

Harbormaster completed remote builds in B22626: Diff 54151.Feb 20 2019, 9:10 PM

Looks good.

sys/kern/init_main.c
112	I wonder if it is more correct that the noop function returns EINVAL, or something like that.

This revision is now accepted and ready to land.Feb 22 2019, 9:43 PM

Closed by commit rS344478: lkpi: allow late binding of linux_alloc_current (authored by mmacy). · Explain WhyFeb 22 2019, 11:15 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

10 lines

src/

linux_current.c

3 lines

kern/

1 line

Diff 54098

sys/compat/linuxkpi/common/include/linux/compat.h

Loading...

sys/compat/linuxkpi/common/src/linux_current.c

Loading...

sys/kern/init_main.c

Loading...