Differential D19214

Fix refcount leak in SGX Linux compat ioctl handlers.
ClosedPublic
Actions

Authored by markj on Feb 16 2019, 6:31 PM.

Tags

None

Referenced Files

	F148333347: D19214.id54016.diff
	Tue, Mar 17, 5:27 AM

	F148333268: D19214.id54016.diff
	Tue, Mar 17, 5:27 AM

	F148316478: D19214.id53991.diff
	Tue, Mar 17, 3:34 AM

	Unknown Object (File)
	Thu, Mar 12, 2:01 PM

	Unknown Object (File)
	Thu, Mar 12, 3:05 AM

	Unknown Object (File)
	Wed, Mar 11, 9:55 PM

	Unknown Object (File)
	Mon, Mar 9, 4:11 PM

	Unknown Object (File)
	Sat, Mar 7, 10:25 AM

View All Files

Subscribers

imp

Details

Reviewers

br
kib

Commits

rS344232: Fix refcount leaks in the SGX Linux compat ioctl handler.

Summary

Also get rid of some debug prints while here.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 22531
Build 21674: arc lint + arc unit

Event Timeline

markj created this revision.Feb 16 2019, 6:31 PM

Harbormaster completed remote builds in B22530: Diff 53991.Feb 16 2019, 6:31 PM

Return the error from copyin(9).

Harbormaster completed remote builds in B22531: Diff 53992.Feb 16 2019, 6:37 PM

markj added reviewers: br, kib.Feb 16 2019, 6:38 PM

kib accepted this revision.Feb 16 2019, 8:26 PM

kib added inline comments.

sys/amd64/sgx/sgx_linux.c
84	Fix style there as well ? (!= 0)

This revision is now accepted and ready to land.Feb 16 2019, 8:26 PM

Closed by commit rS344232: Fix refcount leaks in the SGX Linux compat ioctl handler. (authored by markj). · Explain WhyFeb 17 2019, 4:44 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptFeb 17 2019, 4:44 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

sgx/

sgx_linux.c

16 lines

Diff 53992

View Options

Fix refcount leak in SGX Linux compat ioctl handlers.ClosedPublicActions