Page MenuHomeFreeBSD

bhyve(8) block_if.c remove multiple freeing of nopt added in r340042
ClosedPublic

Authored by rgrimes on Feb 14 2019, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 15 2024, 6:31 PM
Unknown Object (File)
Dec 20 2023, 5:18 AM
Unknown Object (File)
Dec 12 2023, 9:47 PM
Unknown Object (File)
Dec 4 2023, 4:35 AM
Unknown Object (File)
Nov 26 2023, 1:53 AM
Unknown Object (File)
Nov 23 2023, 9:38 AM
Unknown Object (File)
Nov 23 2023, 9:13 AM
Unknown Object (File)
Sep 16 2023, 5:59 PM
Subscribers

Details

Summary

In r340042 an attempt to quiet coverity warning cid 1305412 was overdone.
nopt is the only allocated space, xopt and cp are aliases into that allocated space.

Remove the 2 unneeded free's

Brought to my attention by Patrick Mooney of Joyent/illumos

Test Plan

Visual code inspection.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This is the fix we're applying to SmartOS bhyve, after syncing from upstream.

This revision is now accepted and ready to land.Feb 14 2019, 7:37 PM
This revision was automatically updated to reflect the committed changes.