sfxge: split sfxge_tx_qdpl_put() into _locked() and _unlocked()
ClosedPublic
Actions

Authored by arybchik on May 14 2015, 2:59 PM.

Details

Reviewers

glebius
gnn

Commits

rS282942: sfxge: split sfxge_tx_qdpl_put() into *_locked() and *_unlocked()

Summary

It simplifies understanding of the sfxge_tx_packet_add() logic and
avoids passing of 'locked' to called function.

Sponsored by: Solarflare Communications, Inc.
MFC after: 2 days

It is just the first step in a series of improvements.

Test Plan

Build tested. Driver loaded. Traffic tested.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

arybchik updated this revision to Diff 5386.May 14 2015, 2:59 PM

arybchik retitled this revision from to sfxge: split sfxge_tx_qdpl_put() into *_locked() and *_unlocked().

arybchik updated this object.

arybchik edited the test plan for this revision. (Show Details)

arybchik added reviewers: gnn, glebius.

Herald added a subscriber: imp. · View Herald TranscriptMay 14 2015, 2:59 PM

arybchik updated this object.May 14 2015, 3:01 PM

arybchik added a subscriber: network.

gnn accepted this revision.May 14 2015, 8:08 PM

gnn edited edge metadata.

This revision is now accepted and ready to land.May 14 2015, 8:08 PM

Closed by commit rS282942: sfxge: split sfxge_tx_qdpl_put() into *_locked() and *_unlocked() (authored by arybchik). · Explain WhyMay 15 2015, 6:51 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sfxge/

sfxge_tx.h

2 lines

sfxge_tx.c

141 lines

Diff 5386

View Options

sys/dev/sfxge/sfxge_tx.h