Page MenuHomeFreeBSD
Differential D19112

devel/libgrading: update v0.1.2 -> v0.1.6
ClosedPublic
Actions

Authored by jonathan on Feb 7 2019, 11:04 PM.
Tags
None
Referenced Files
F136145645: D19112.diff
Sun, Nov 16, 4:09 AM
Unknown Object (File)
Wed, Nov 12, 6:41 AM
Unknown Object (File)
Wed, Nov 5, 4:41 AM
Unknown Object (File)
Mon, Nov 3, 2:17 AM
Unknown Object (File)
Sun, Nov 2, 10:51 AM
Unknown Object (File)
Sat, Nov 1, 10:48 AM
Unknown Object (File)
Sat, Nov 1, 2:25 AM
Unknown Object (File)
Fri, Oct 31, 9:19 PM
View All Files
Subscribers
matthew
tobik

Details

Reviewers
tobik
matthew
Group Reviewers
Contributor Reviewers (ports)
Commits
rP493150: devel/libgrading: update v0.1.2 -> v0.1.7.
Summary
  • Add support for Gradescope
  • Fix SOVERSION
  • Various minor fixups

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 22392
Build 21556: arc lint + arc unit

Event Timeline

jonathan created this revision.Feb 7 2019, 11:04 PM
Harbormaster completed remote builds in B22385: Diff 53675.Feb 7 2019, 11:04 PM
jonathan added a reviewer: Contributor Reviewers (ports).Feb 7 2019, 11:04 PM
tobik requested changes to this revision.Feb 8 2019, 7:58 AM
tobik added a subscriber: tobik.

This fails check-plist:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/libgrading.so.0.1.4
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
This revision now requires changes to proceed.Feb 8 2019, 7:58 AM
matthew accepted this revision.Feb 8 2019, 7:58 AM
matthew added a subscriber: matthew.
This comment was removed by matthew.
matthew requested changes to this revision.Feb 8 2019, 8:00 AM

Ooops. I was too quick to accept there. Needs pkg-plist updating as @tobik has shown

jonathan updated this revision to Diff 53691.Feb 8 2019, 5:26 PM
  • Add new library to plist
  • Fix library version.
  • Fix a portlint warning.
  • Update patch file (new line numbers, etc.).
Harbormaster completed remote builds in B22392: Diff 53691.Feb 8 2019, 5:26 PM
jonathan added a comment.Feb 8 2019, 5:27 PM

Thanks for the feedback: I've added the missing file and done a little extra tidy-up that portlint -A suggested while I'm at it.

jonathan updated this revision to Diff 53700.Feb 8 2019, 6:55 PM
  • Update to v0.1.7 (w/upstream patch adoption).
Harbormaster completed remote builds in B22397: Diff 53700.Feb 8 2019, 6:55 PM
jonathan added a comment.Feb 8 2019, 7:05 PM

Just for good measure, I also updated the upstream code to incorporate the __FreeBSD_version_ patch; I'm now looking to update the port to v0.1.7.

matthew accepted this revision.Feb 8 2019, 7:42 PM

LGTM

tobik accepted this revision.Feb 8 2019, 8:30 PM
This revision is now accepted and ready to land.Feb 8 2019, 8:30 PM
Closed by commit rP493150: devel/libgrading: update v0.1.2 -> v0.1.7. (authored by jonathan). · Explain WhyFeb 17 2019, 3:04 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
libgrading/
7 lines
6 lines
files/
13 lines
4 lines

Diff 53691

View Options

devel/libgrading/Makefile

Loading...
View Options

devel/libgrading/distinfo

Loading...
View Options

devel/libgrading/files/patch-src_CMakeLists.txt

Loading...
View Options

devel/libgrading/files/patch-src_posix.cpp

Loading...