Page MenuHomeFreeBSD
Differential D2521

Handle X2APIC entries for APICs with an ID < 255.
ClosedPublic
Actions

Authored by jhb on May 12 2015, 3:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 2:26 PM
Unknown Object (File)
Mon, Nov 18, 11:58 AM
Unknown Object (File)
Sat, Nov 16, 7:57 AM
Unknown Object (File)
Thu, Nov 7, 3:59 PM
Unknown Object (File)
Oct 10 2024, 10:44 PM
Unknown Object (File)
Oct 1 2024, 7:56 AM
Unknown Object (File)
Oct 1 2024, 5:38 AM
Unknown Object (File)
Sep 26 2024, 2:01 AM
View All Files
Subscribers
imp
zeising

Details

Reviewers
kib
Commits
rS284175: Handle X2APIC entries in the MADT for APICs with an ID < 255. At least one

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

jhb updated this revision to Diff 5342.May 12 2015, 3:51 PM
jhb retitled this revision from to Handle X2APIC entries for APICs with an ID < 255..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: kib.
Herald added a subscriber: imp. · View Herald TranscriptMay 12 2015, 3:51 PM
kib edited edge metadata.May 12 2015, 3:57 PM

I think this is fine as the quick patch, but could we share the code with madt_parse_apics() and with madt_parse_local_nmi() ? I suppose some short helpers would do it.

sys/x86/acpica/madt.c
324

I think this should be LocalApicId and not Uid.

zeising added a subscriber: zeising.May 12 2015, 4:01 PM
jhb added inline comments.May 12 2015, 4:19 PM
sys/x86/acpica/madt.c
324

la_acpi_id is supposed to be the ID ACPI uses. It corresponds to the field present in the NMI entry (which is Uid for X2APIC and ProcessorID for plain APIC).

kib accepted this revision.May 12 2015, 4:27 PM
kib edited edge metadata.
This revision is now accepted and ready to land.May 12 2015, 4:27 PM
jhb updated this revision to Diff 5355.May 12 2015, 8:53 PM
jhb edited edge metadata.
  • Use helper routines to reduce duplicated code.
This revision now requires review to proceed.May 12 2015, 8:53 PM
kib accepted this revision.May 12 2015, 9:17 PM
kib edited edge metadata.
This revision is now accepted and ready to land.May 12 2015, 9:17 PM
jhb added a comment.Jun 8 2015, 6:15 PM

FYI, I finally boot tested this on a machine with a normal MADT (no x2APIC entries) and verified that it still booted ok. I still haven't heard anything from zeising in regards to testing on the HP machine that needs this.

kib added a comment.Jun 9 2015, 1:59 AM

IMO it does not make sense to sit on the patch. On the non-buggy BIOSes, the patch should make no change. Supposedly, the patch fixes the buggy case, which is not working right now anyway. So even if, unlikely, there is some bug preventing the Dells from booting, the machines cannot boot now. But there is high chance that they would boot. Also, x2apic entries parsing is the required step.

Closed by commit rS284175: Handle X2APIC entries in the MADT for APICs with an ID < 255. At least one (authored by jhb). · Explain WhyJun 9 2015, 10:49 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
x86/
acpica/
97 lines

Diff 5355

View Options

sys/x86/acpica/madt.c

Loading...