Differential D18957

Switch rubygem dependencies from rails4 to rails50 for deps required by gitlab-ce 11.7 upgrade
ClosedPublic
Actions

Authored by mfechner on Jan 25 2019, 5:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 5, 10:04 PM

	Unknown Object (File)
	Thu, Dec 5, 11:06 AM

	Unknown Object (File)
	Sun, Nov 24, 6:26 PM

	Unknown Object (File)
	Nov 21 2024, 3:42 PM

	Unknown Object (File)
	Nov 19 2024, 1:11 PM

	Unknown Object (File)
	Nov 9 2024, 12:57 AM

	Unknown Object (File)
	Nov 5 2024, 2:19 PM

	Unknown Object (File)
	Oct 28 2024, 9:26 PM

View All 95 Files

Subscribers

Details

Reviewers

sunpoet
kuriyama
tz
swills

Commits

rP491838: MFH: r491723
rP491723: In preparation for gitlab 11.7 upgrade switch rails4 to rails50.

Summary

In preparation for gitlab 11.7.0 upgrade which I finished and already tested successfully I switched all ports gitlab-ce requires from rails4 to rails50.

As I touch here ports you are the maintainer, could you please have a look over it.
I want to make sure to not break by accident a port I have not on my monitor.

If you agree on this review, I will later commit it together with gitlab 11.7 upgrade.
You can find all modification that are required here:
https://gitlab.fechner.net/mfechner/Gitlab/commits/11.7

Test Plan

I have testbuild gitlab-ce and redmine.
I have done instensive tests for gitlab 11.7.

So far I could not found a problem.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

mfechner created this revision.Jan 25 2019, 5:23 PM

Herald added a subscriber: mat. · View Herald TranscriptJan 25 2019, 5:23 PM

mfechner retitled this revision from Switch rubygem dependencies from rails4 to rails50 to Switch rubygem dependencies from rails4 to rails50 for deps required by gitlab-ce 11.7 upgrade.Jan 25 2019, 5:25 PM

sunpoet added inline comments.Jan 28 2019, 9:44 PM

www/rubygem-json-jwt/Makefile
15	security/rubygem-rack-oauth2 depends on www/rubygem-json-jwt. Please also update security/rubygem-rack-oauth2 to avoid mixed rails 4.2 and 5.0 dependencies after this change.

Updated the diff to also include security/rubygem-rack-oauth2

mfechner marked an inline comment as done.Jan 28 2019, 11:05 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 30 2019, 11:13 AM

Closed by commit rP491723: In preparation for gitlab 11.7 upgrade switch rails4 to rails50. (authored by mfechner). · Explain WhyJan 31 2019, 2:06 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

databases/

mariadb103-client/

1 line

rubygem-flipper-active_record/

8 lines

rubygem-flipper-active_record013/

10 lines

rubygem-seed-fu/

11 lines

6 lines

rubygem-state_machines-activemodel/

8 lines

rubygem-state_machines-activerecord/

8 lines

devel/

rubygem-flipper-active_support_cache_store/

8 lines

rubygem-flipper-active_support_cache_store013/

10 lines

rubygem-grape-entity/

8 lines

rubygem-grape-path-helpers/

2 lines

rubygem-grape/

3 lines

rubygem-grape11/

3 lines

rubygem-jira-ruby/

4 lines

rubygem-omniauth_crowd22/

10 lines

dns/

rubygem-validates_hostname/

10 lines

net/

rubygem-omniauth-authentiq/

8 lines

security/

rubygem-rack-oauth2/

2 lines

rubygem-rack-oauth212/

10 lines

textproc/

rubygem-html-pipeline/

4 lines

6 lines

www/

rubygem-acts-as-taggable-on/

6 lines

rubygem-json-jwt/

3 lines

Diff 53349

databases/mariadb103-client/pkg-plist

Loading...

databases/rubygem-flipper-active_record/Makefile

Loading...

databases/rubygem-flipper-active_record013/Makefile

Loading...

databases/rubygem-seed-fu/Makefile

Loading...

databases/rubygem-seed-fu/distinfo

Loading...

databases/rubygem-state_machines-activemodel/Makefile

Loading...

databases/rubygem-state_machines-activerecord/Makefile

Loading...

devel/rubygem-flipper-active_support_cache_store/Makefile

Loading...

devel/rubygem-flipper-active_support_cache_store013/Makefile

Loading...

devel/rubygem-grape-entity/Makefile

Loading...

devel/rubygem-grape-path-helpers/Makefile

Loading...

devel/rubygem-grape/Makefile

Loading...

devel/rubygem-grape11/Makefile

Loading...

devel/rubygem-jira-ruby/Makefile

Loading...

devel/rubygem-omniauth_crowd22/Makefile

Loading...

dns/rubygem-validates_hostname/Makefile

Loading...

net/rubygem-omniauth-authentiq/Makefile

Loading...

security/rubygem-rack-oauth2/Makefile

Loading...

security/rubygem-rack-oauth212/Makefile

Loading...

textproc/rubygem-html-pipeline/Makefile

Loading...

textproc/rubygem-html-pipeline/distinfo

Loading...

www/rubygem-acts-as-taggable-on/Makefile

Loading...

www/rubygem-json-jwt/Makefile

Loading...