Use the cpuset API more consistently.
ClosedPublic
Actions

Authored by jhb on May 8 2015, 8:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sep 23 2024, 1:25 AM

	Unknown Object (File)
	Sep 22 2024, 3:21 PM

	Unknown Object (File)
	Sep 22 2024, 10:01 AM

	Unknown Object (File)
	Sep 22 2024, 9:12 AM

	Unknown Object (File)
	Sep 22 2024, 9:11 AM

	Unknown Object (File)
	Sep 22 2024, 9:11 AM

	Unknown Object (File)
	Sep 22 2024, 9:11 AM

	Unknown Object (File)
	Sep 22 2024, 9:01 AM

View All 69 Files

Subscribers

imp

Details

Reviewers

emaste
davide

Commits

rS283613: Use the cpuset API more consistently:

Summary

Use the cpuset API more consistently:

Fetch the root set from cpuset_getaffinity() instead of assuming all CPUs from 0 to hw.ncpu are the root set.
Use CPU_SETSIZE and CPU_FFS.
The original notion of halted CPUs the manpage and code refers to is gone. Use the term "available" instead.

Test Plan

I've been running pmcstat with this for my other pmcstat testing recently.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

jhb updated this revision to Diff 5295.May 8 2015, 8:57 PM

jhb retitled this revision from to Use the cpuset API more consistently..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added reviewers: emaste, davide.

Herald added a subscriber: imp. · View Herald TranscriptMay 8 2015, 8:57 PM

Any thoughts?

No objection from me

This revision is now accepted and ready to land.May 26 2015, 7:52 PM

Closed by commit rS283613: Use the cpuset API more consistently: (authored by jhb). · Explain WhyMay 27 2015, 1:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

pmcstat/

pmcstat.8

4 lines

pmcstat.c

45 lines

Diff 5295

View Options

usr.sbin/pmcstat/pmcstat.8