Page MenuHomeFreeBSD
Differential D18349

Simplify some of the logic for external GCC toolchain packages.
ClosedPublic
Actions

Authored by jhb on Nov 26 2018, 9:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 20, 1:52 PM
Unknown Object (File)
Sun, Apr 7, 8:42 AM
Unknown Object (File)
Mar 3 2024, 4:02 PM
Unknown Object (File)
Jan 14 2024, 5:03 PM
Unknown Object (File)
Dec 20 2023, 3:46 AM
Unknown Object (File)
Dec 9 2023, 5:49 AM
Unknown Object (File)
Oct 28 2023, 6:29 PM
Unknown Object (File)
Oct 28 2023, 6:28 PM
View All 26 Files
Subscribers
mat
zeising

Details

Reviewers
kan
zeising
Commits
rP488642: Simplify some of the logic for external GCC toolchain packages.
Summary
  • Always define BU_PREFIX as GCC_TARGET if needed. This was already effectively true, but BU_PREFIX was just being set to the same value in the case that GCC_TARGET wasn't defined. This is simpler and avoids duplicating some logic.
  • Simplify amd64-gcc by not defining GCC_TARGET and BU_PREFIX in that port but instead replacing "amd64" with "x86_64" in the devel/powerpc64-gcc Makefile. This matches what base/gcc does.
  • Remove FREEBSD_EXTENSION now that it is no longer needed.
Test Plan
  • built amd64-xtoolchain-gcc and verified it could still build world (modulo the fact that world doesn't currently build due to various warnings)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Nov 26 2018, 9:55 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 26 2018, 9:55 PM
jhb added a parent revision: D18348: devel/i386-gcc: Remove spurious macro assignment..Nov 26 2018, 9:55 PM
Harbormaster completed remote builds in B21213: Diff 51139.Nov 26 2018, 9:56 PM
jhb marked an inline comment as done.Nov 26 2018, 9:57 PM
jhb added inline comments.
devel/powerpc64-gcc/Makefile
32 ↗(On Diff #51139)

This could perhaps use TARGETARCH instead of repeating the similar expression.

zeising accepted this revision.Dec 28 2018, 8:06 PM
zeising added a subscriber: zeising.

lgtm

This revision is now accepted and ready to land.Dec 28 2018, 8:06 PM
Closed by commit rP488642: Simplify some of the logic for external GCC toolchain packages. (authored by jhb). · Explain WhyDec 29 2018, 12:44 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
devel/
amd64-gcc/
3 lines
powerpc64-gcc/
13 lines

Diff 52385

View Options

head/devel/amd64-gcc/Makefile

Loading...
View Options

head/devel/powerpc64-gcc/Makefile

Loading...