Page MenuHomeFreeBSD

Simplify some of the logic for external GCC toolchain packages.
ClosedPublic

Authored by jhb on Nov 26 2018, 9:55 PM.

Details

Summary
  • Always define BU_PREFIX as GCC_TARGET if needed. This was already effectively true, but BU_PREFIX was just being set to the same value in the case that GCC_TARGET wasn't defined. This is simpler and avoids duplicating some logic.
  • Simplify amd64-gcc by not defining GCC_TARGET and BU_PREFIX in that port but instead replacing "amd64" with "x86_64" in the devel/powerpc64-gcc Makefile. This matches what base/gcc does.
  • Remove FREEBSD_EXTENSION now that it is no longer needed.
Test Plan
  • built amd64-xtoolchain-gcc and verified it could still build world (modulo the fact that world doesn't currently build due to various warnings)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21213
Build 20562: arc lint + arc unit

Event Timeline

jhb created this revision.Nov 26 2018, 9:55 PM
jhb marked an inline comment as done.Nov 26 2018, 9:57 PM
jhb added inline comments.
devel/powerpc64-gcc/Makefile
32

This could perhaps use TARGETARCH instead of repeating the similar expression.

zeising accepted this revision.Dec 28 2018, 8:06 PM
zeising added a subscriber: zeising.

lgtm

This revision is now accepted and ready to land.Dec 28 2018, 8:06 PM
This revision was automatically updated to reflect the committed changes.