Differential D18570

fsck_ffs: make rwerror() report errno.
AbandonedPublic
Actions

Authored by trasz on Dec 15 2018, 11:45 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 2:46 AM

	Unknown Object (File)
	Mon, May 18, 2:46 AM

	Unknown Object (File)
	Mon, May 18, 2:45 AM

	Unknown Object (File)
	Tue, Apr 21, 12:24 AM

	Unknown Object (File)
	Apr 19 2026, 3:29 AM

	Unknown Object (File)
	Apr 18 2026, 2:46 AM

	Unknown Object (File)
	Apr 17 2026, 12:23 PM

	Unknown Object (File)
	Apr 12 2026, 3:28 PM

View All 72 Files

Subscribers

Details

Reviewers

kib
mckusick

Summary

Make rwerror() report errno.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21587
Build 20890: arc lint + arc unit

Event Timeline

trasz created this revision.Dec 15 2018, 11:45 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 15 2018, 11:45 AM

trasz added reviewers: kib, mckusick.Dec 15 2018, 11:45 AM

Harbormaster completed remote builds in B21587: Diff 52051.Dec 15 2018, 11:46 AM

kib added inline comments.Dec 15 2018, 1:30 PM

sbin/fsck_ffs/fsutil.c
390	This is not going to work. E.g. the printf() above can obliterate errno. Similarly, the cases of short or zero-length writes do not set errno at all.

trasz abandoned this revision.Jun 15 2019, 8:40 AM

Revision Contents
Changeset List

Path

Size

sbin/

fsck_ffs/

2 lines

Diff 52051

sbin/fsck_ffs/fsutil.c

Loading...