Page MenuHomeFreeBSD
Differential D18493

Check if NVMe Controller supports Dataset Management in nda(4)
ClosedPublic
Actions

Authored by chuck on Dec 10 2018, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 31, 8:46 AM
Unknown Object (File)
Mon, Aug 31, 12:41 AM
Unknown Object (File)
Sun, Aug 30, 8:00 AM
Unknown Object (File)
Sat, Aug 29, 8:21 AM
Unknown Object (File)
Sat, Aug 29, 12:49 AM
Unknown Object (File)
Wed, Aug 26, 8:59 AM
Unknown Object (File)
Wed, Aug 26, 7:22 AM
Unknown Object (File)
Tue, Aug 25, 12:24 PM
View All Files
Subscribers
None

Details

Reviewers
imp
ken
mav
jimharris
Commits
rS342046: nda(4) fix check for Dataset Management support
Summary

In the nda(4) driver, only set DISKFLAG_CANDELETE (a.k.a. can support BIO_DELETE) if the drive supports Dataset Management. There are reports that without this check, VMWare Workstation does not work reliably.

Fix is to check the ONCS field in the NVMe Controller Data structure for support. This check previously existed but did not survive the big-endian changes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 21466

Revision Contents
Changeset List

PathSize
sys/
cam/
nvme/
2 lines
dev/
nvme/
7 lines
6 lines

Diff 51794

View Options

sys/cam/nvme/nvme_da.c

Loading...
View Options

sys/dev/nvme/nvme.h

Loading...
View Options

sys/dev/nvme/nvme_ns.c

Loading...