x11/i3blocks: A minimalist scheduler for your status bar scripts [NEW PORT]
ClosedPublic
Actions

Authored by rigoletto on Dec 7 2018, 12:29 AM.

Details

Reviewers

mat
tcberner

Commits

rP487546: x11/i3blocks: a minimalist scheduler for your status line scripts.

Summary

PR 230748

The ports needs a bunch of patches to work on FreeBSD, the maintainer actually forked it on GitHub and the source is got from there. Is it needed to be mentioned anywhere?

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 21456
Build 20775: arc lint + arc unit

Event Timeline

rigoletto created this revision.Dec 7 2018, 12:29 AM

Harbormaster completed remote builds in B21415: Diff 51696.Dec 7 2018, 12:29 AM

rigoletto edited the summary of this revision. (Show Details)Dec 7 2018, 12:29 AM

tcberner added inline comments.Dec 8 2018, 1:15 PM

x11/i3blocks/Makefile
2	^ Please ask the submitter if they are fine with dropping this :)
17	^ > git describe --tags fcee4e0 1.4-93-gfcee4e0 So you can set DISTVERSION=1.4-93 DISTVERSIONSUFFIX=-gfcee4e0 and drop the `GH_TAGNAME` See: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5
20	^ is that a normal man page or some markdown file?

rigoletto marked 3 inline comments as done.Dec 8 2018, 3:24 PM

rigoletto added inline comments.

x11/i3blocks/Makefile
2	Yes, I don't like this created by thing too.
17	I didn't touch on these yet because I am waiting the submitter/maintainer to reply in the Forums or Bugs about the fork. If he/she will extract the patches or try to upstream them or keep his/her fork.
20	More or less like the previous one. But I will take a look. :-)

mat added inline comments.Dec 9 2018, 10:27 AM

x11/i3blocks/Makefile
2	The reason we have committers and not a script that commits patchs submitted in bugzilla automatically is so that committers clean things up. Simply remove this line.

Fix the versioning, and the extra documentation.
There is no reply yet from the maintainer.

Thanks!

Harbormaster completed remote builds in B21455: Diff 51778.Dec 9 2018, 5:07 PM

rigoletto marked an inline comment as done.Dec 9 2018, 5:08 PM

Silent directory creation.

Harbormaster completed remote builds in B21456: Diff 51779.Dec 9 2018, 5:10 PM

git describe --tags fcee4e0
1.4-93-gfcee4e0

The current version actually is 1.5, and IIRC it is just the TAG number that matter. Can DISTVERSION be:

1.5-93-gfcee4e0

Thanks!

In D18466#394013, @rigoletto wrote:

git describe --tags fcee4e0
1.4-93-gfcee4e0

The current version actually is 1.5, and IIRC it is just the TAG number that matter. Can DISTVERSION be:

1.5-93-gfcee4e0

Thanks!

If there is a 1.5 tag, that is at the fcee40e commit, then git describe --tags should say 1.5.

As it happens, there is no 1.5 tag, and nothing that says 1.5 in the commit history either. So I do not think there it should be 1.5.

Looks good to me.

This revision is now accepted and ready to land.Dec 15 2018, 8:35 PM

Closed by commit rP487546: x11/i3blocks: a minimalist scheduler for your status line scripts. (authored by rigoletto). · Explain WhyDec 15 2018, 9:01 PM

This revision was automatically updated to reflect the committed changes.