Page MenuHomeFreeBSD

x11/i3blocks: A minimalist scheduler for your status bar scripts [NEW PORT]
ClosedPublic

Authored by rigoletto on Dec 7 2018, 12:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 10, 5:24 PM
Unknown Object (File)
Sun, Mar 10, 5:24 PM
Unknown Object (File)
Sun, Mar 10, 5:24 PM
Unknown Object (File)
Sun, Mar 10, 5:24 PM
Unknown Object (File)
Sun, Mar 10, 5:21 PM
Unknown Object (File)
Sun, Mar 10, 4:40 PM
Unknown Object (File)
Dec 22 2023, 12:29 AM
Unknown Object (File)
Dec 20 2023, 8:22 AM
Subscribers
None

Details

Summary

PR 230748

The ports needs a bunch of patches to work on FreeBSD, the maintainer actually forked it on GitHub and the source is got from there. Is it needed to be mentioned anywhere?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

x11/i3blocks/Makefile
1 ↗(On Diff #51696)

^ Please ask the submitter if they are fine with dropping this :)

16 ↗(On Diff #51696)

^

> git describe --tags fcee4e0                                                                                               
1.4-93-gfcee4e0

So you can set

DISTVERSION=1.4-93
DISTVERSIONSUFFIX=-gfcee4e0

and drop the GH_TAGNAME

See: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5

19 ↗(On Diff #51696)

^ is that a normal man page or some markdown file?

rigoletto added inline comments.
x11/i3blocks/Makefile
1 ↗(On Diff #51696)

Yes, I don't like this created by thing too.

16 ↗(On Diff #51696)

I didn't touch on these yet because I am waiting the submitter/maintainer to reply in the Forums or Bugs about the fork. If he/she will extract the patches or try to upstream them or keep his/her fork.

19 ↗(On Diff #51696)

More or less like the previous one. But I will take a look. :-)

x11/i3blocks/Makefile
1 ↗(On Diff #51696)

The reason we have committers and not a script that commits patchs submitted in bugzilla automatically is so that committers clean things up. Simply remove this line.

rigoletto marked 3 inline comments as done.

Fix the versioning, and the extra documentation.
There is no reply yet from the maintainer.

Thanks!

git describe --tags fcee4e0
1.4-93-gfcee4e0

The current version actually is 1.5, and IIRC it is just the TAG number that matter. Can DISTVERSION be:

1.5-93-gfcee4e0

Thanks!

git describe --tags fcee4e0
1.4-93-gfcee4e0

The current version actually is 1.5, and IIRC it is just the TAG number that matter. Can DISTVERSION be:

1.5-93-gfcee4e0

Thanks!

If there is a 1.5 tag, that is at the fcee40e commit, then git describe --tags should say 1.5.

As it happens, there is no 1.5 tag, and nothing that says 1.5 in the commit history either. So I do not think there it should be 1.5.

This revision is now accepted and ready to land.Dec 15 2018, 8:35 PM
This revision was automatically updated to reflect the committed changes.