Page MenuHomeFreeBSD

x11/i3blocks: A minimalist scheduler for your status bar scripts [NEW PORT]
Needs ReviewPublic

Authored by rigoletto on Fri, Dec 7, 12:29 AM.

Details

Reviewers
mat
tcberner
Summary

PR 230748

The ports needs a bunch of patches to work on FreeBSD, the maintainer actually forked it on GitHub and the source is got from there. Is it needed to be mentioned anywhere?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 21456
Build 20775: arc lint + arc unit

Event Timeline

rigoletto created this revision.Fri, Dec 7, 12:29 AM
rigoletto edited the summary of this revision. (Show Details)Fri, Dec 7, 12:29 AM
tcberner added inline comments.Sat, Dec 8, 1:15 PM
x11/i3blocks/Makefile
2

^ Please ask the submitter if they are fine with dropping this :)

17

^

> git describe --tags fcee4e0                                                                                               
1.4-93-gfcee4e0

So you can set

DISTVERSION=1.4-93
DISTVERSIONSUFFIX=-gfcee4e0

and drop the GH_TAGNAME

See: https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5

20

^ is that a normal man page or some markdown file?

rigoletto marked 3 inline comments as done.Sat, Dec 8, 3:24 PM
rigoletto added inline comments.
x11/i3blocks/Makefile
2

Yes, I don't like this created by thing too.

17

I didn't touch on these yet because I am waiting the submitter/maintainer to reply in the Forums or Bugs about the fork. If he/she will extract the patches or try to upstream them or keep his/her fork.

20

More or less like the previous one. But I will take a look. :-)

mat added inline comments.Sun, Dec 9, 10:27 AM
x11/i3blocks/Makefile
2

The reason we have committers and not a script that commits patchs submitted in bugzilla automatically is so that committers clean things up. Simply remove this line.

rigoletto updated this revision to Diff 51778.Sun, Dec 9, 5:07 PM
rigoletto marked 3 inline comments as done.

Fix the versioning, and the extra documentation.
There is no reply yet from the maintainer.

Thanks!

rigoletto marked an inline comment as done.Sun, Dec 9, 5:08 PM
rigoletto updated this revision to Diff 51779.Sun, Dec 9, 5:09 PM

Silent directory creation.

git describe --tags fcee4e0
1.4-93-gfcee4e0

The current version actually is 1.5, and IIRC it is just the TAG number that matter. Can DISTVERSION be:

1.5-93-gfcee4e0

Thanks!

mat added a comment.Mon, Dec 10, 4:42 PM

git describe --tags fcee4e0
1.4-93-gfcee4e0

The current version actually is 1.5, and IIRC it is just the TAG number that matter. Can DISTVERSION be:

1.5-93-gfcee4e0

Thanks!

If there is a 1.5 tag, that is at the fcee40e commit, then git describe --tags should say 1.5.

As it happens, there is no 1.5 tag, and nothing that says 1.5 in the commit history either. So I do not think there it should be 1.5.