Page MenuHomeFreeBSD

sfxge(4): use simpler code to check hash algorithm type
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 27, 12:44 PM
Unknown Object (File)
Thu, Apr 23, 6:25 PM
Unknown Object (File)
Wed, Apr 22, 10:50 PM
Unknown Object (File)
Wed, Apr 22, 8:01 AM
Unknown Object (File)
Tue, Apr 21, 12:07 AM
Unknown Object (File)
Mon, Apr 20, 12:36 PM
Unknown Object (File)
Sun, Apr 19, 11:51 PM
Unknown Object (File)
Sun, Apr 19, 11:50 PM
Subscribers

Details

Summary

The API which is used to list supported hash flags verifies
hash algorithm choice before writing the output. This check
is based on a switch() statement which has only two options
and no distinctive actions to be conducted for each of them.
Use simpler code instead of switch() to improve readability.

Submitted by: Ivan Malov <ivan.malov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM
This revision was automatically updated to reflect the committed changes.