Page MenuHomeFreeBSD

sfxge(4): use simpler code to check hash algorithm type
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:56 AM.
Tags
None
Referenced Files
F88444070: D18266.id.diff
Mon, Jul 15, 5:45 AM
Unknown Object (File)
Thu, Jul 11, 12:25 PM
Unknown Object (File)
Thu, Jul 11, 2:55 AM
Unknown Object (File)
Jun 3 2024, 11:09 AM
Unknown Object (File)
Apr 29 2024, 7:28 AM
Unknown Object (File)
Dec 23 2023, 2:51 AM
Unknown Object (File)
Dec 14 2023, 9:45 AM
Unknown Object (File)
Sep 4 2023, 3:28 PM
Subscribers

Details

Summary

The API which is used to list supported hash flags verifies
hash algorithm choice before writing the output. This check
is based on a switch() statement which has only two options
and no distinctive actions to be conducted for each of them.
Use simpler code instead of switch() to improve readability.

Submitted by: Ivan Malov <ivan.malov at oktetlabs.ru>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21124
Build 20487: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:07 AM
This revision was automatically updated to reflect the committed changes.