Details
- Reviewers
kib emaste - Commits
- rS282314: Import reallocarray(3) from OpenBSD
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage
Event Timeline
Remove not intended changes
Updating D2420: Import reallocarray from OpenBSD
Write a manpage about it (assign copyright to openbsd given the manpage is
maintly copy/paste from OpenBSD malloc(3))
Add to version map
Updating D2420: Import reallocarray from OpenBSD
Write a manpage about it (assign copyright to openbsd given the manpage is
maintly copy/paste from OpenBSD malloc(3))
erg I forgot the Makefile in the review
Updating D2420: Import reallocarray from OpenBSD
Write a manpage about it (assign copyright to openbsd given the manpage is
maintly copy/paste from OpenBSD malloc(3))
netbsd ended up with there own implementation and an openbsd compatible stub
http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/stdlib/reallocarray.c
http://cvsweb.netbsd.org/bsdweb.cgi/src/lib/libc/stdlib/reallocarray.c
I can switch to their version if that is preferred
and what openbsd thinks about netbsd versions: http://www.tedunangst.com/flak/post/invented-by-openbsd
I do not want to participate in the discussion about the API design.
The symver usage seems correct.
| lib/libc/stdlib/reallocarray.c | ||
|---|---|---|
| 18 | The $FreeBSD$ should not appear in the license comment for the non-vendor .c source. The approved way to introduce idtag is to use __FBSDID(), look at the other sources for examples. | |
| 35 | There should be empty line after '{' if no local vars are declared. | |
| 38 | return (NULL); | |
| 40 | Again, return (realloc()); | |
Fix issues reported by kib
Updating D2420: Import reallocarray from OpenBSD
Write a manpage about it (assign copyright to openbsd given the manpage is
maintly copy/paste from OpenBSD malloc(3))
Fixed a missed one
Updating D2420: Import reallocarray from OpenBSD
Write a manpage about it (assign copyright to openbsd given the manpage is
maintly copy/paste from OpenBSD malloc(3))