Differential D18381

Allow to create swap zone larger than v_page_count / 2.
ClosedPublic
Actions

Authored by kib on Nov 29 2018, 6:36 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Apr 3, 1:56 AM

	Unknown Object (File)
	Tue, Mar 31, 8:48 PM

	Unknown Object (File)
	Tue, Mar 31, 9:19 AM

	Unknown Object (File)
	Tue, Mar 31, 4:18 AM

	Unknown Object (File)
	Mon, Mar 23, 12:20 AM

	Unknown Object (File)
	Sat, Mar 21, 6:22 AM

	Unknown Object (File)
	Sat, Mar 21, 4:22 AM

	Unknown Object (File)
	Wed, Mar 18, 3:58 AM

Subscribers

Details

Reviewers

alc
markj

Commits

rS341375: Allow to create swap zone larger than v_page_count / 2.

Summary

If user configured maxswapzone tunable, just take the literal value for the initial zone sizing attempt. Before, it was only possible to reduce the zone by a tunable.

Reported by: jmg

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 21269

Event Timeline

kib created this revision.Nov 29 2018, 6:36 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 29 2018, 6:36 PM

Harbormaster completed remote builds in B21264: Diff 51363.Nov 29 2018, 6:36 PM

markj accepted this revision.Nov 29 2018, 9:40 PM

markj added inline comments.

sys/vm/swap_pager.c
550–552	Perhaps, "taking the user's requested size or estimating the number we need..."?
583	Did you make this change because uma_zone_reserve_kva() can round up?

This revision is now accepted and ready to land.Nov 29 2018, 9:40 PM

Comment rewording.

This revision now requires review to proceed.Nov 29 2018, 10:38 PM

kib marked an inline comment as done.Nov 29 2018, 10:39 PM

kib added inline comments.

sys/vm/swap_pager.c
583	Yes, somebody noted it to me long time ago, but I did not considered it worth fixing alone.

Harbormaster completed remote builds in B21269: Diff 51370.Nov 29 2018, 10:40 PM

markj accepted this revision.Nov 29 2018, 10:44 PM

This revision is now accepted and ready to land.Nov 29 2018, 10:44 PM

Closed by commit rS341375: Allow to create swap zone larger than v_page_count / 2. (authored by kib). · Explain WhyDec 1 2018, 4:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

vm/

12 lines

Diff 51370

sys/vm/swap_pager.c

Loading...