Avoid unneeded check in vmspace_alloc().
ClosedPublic
Actions

Authored by kib on Nov 25 2018, 8:34 AM.

Details

Reviewers

alc
markj

Commits

rS340922: Avoid unneeded check in vmspace_alloc().

Summary

All vmspace_alloc() callers know which kind of pmap they allocate.

Test Plan

Booted multiuser, ran bhyve vm.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Nov 25 2018, 8:34 AM

Herald added a subscriber: imp. · View Herald TranscriptNov 25 2018, 8:34 AM

Harbormaster completed remote builds in B21195: Diff 51084.Nov 25 2018, 8:37 AM

markj accepted this revision.Nov 25 2018, 5:12 PM

This revision is now accepted and ready to land.Nov 25 2018, 5:12 PM

alc accepted this revision.Nov 25 2018, 5:47 PM

alc added inline comments.

sys/vm/vm_map.c
3423 ↗	(On Diff #51084)	The `&` is unnecessary.
3974 ↗	(On Diff #51084)	Ditto.

Closed by commit rS340922: Avoid unneeded check in vmspace_alloc(). (authored by kib). · Explain WhyNov 25 2018, 5:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

vm/

vm_map.c

10 lines

Diff 51090

View Options

head/sys/vm/vm_map.c

Show First 20 Lines • Show All 301 Lines • ▼ Show 20 Lines	main(int argc, char *argv[])
int cc, i;		int cc, i;
int almost_done, ch, hold, packlen, preload, optval, error;		int almost_done, ch, hold, packlen, preload, optval, error;
int nig_oldmcprefix = -1;		int nig_oldmcprefix = -1;
u_char *datap;		u_char *datap;
char e, target, ifname = NULL, gateway = NULL;		char e, target, ifname = NULL, gateway = NULL;
int ip6optlen = 0;		int ip6optlen = 0;
struct cmsghdr *scmsgp = NULL;		struct cmsghdr *scmsgp = NULL;
/* For control (ancillary) data received from recvmsg() */		/* For control (ancillary) data received from recvmsg() */
struct cmsghdr cm[CONTROLLEN];		u_char cm[CONTROLLEN];
#if defined(SO_SNDBUF) && defined(SO_RCVBUF)		#if defined(SO_SNDBUF) && defined(SO_RCVBUF)
u_long lsockbufsize;		u_long lsockbufsize;
int sockbufsize = 0;		int sockbufsize = 0;
#endif		#endif
int usepktinfo = 0;		int usepktinfo = 0;
struct in6_pktinfo pktinfo;		struct in6_pktinfo pktinfo;
char *cmsg_pktinfo = NULL;		char *cmsg_pktinfo = NULL;
struct ip6_rthdr *rthdr = NULL;		struct ip6_rthdr *rthdr = NULL;
▲ Show 20 Lines • Show All 2,517 Lines • Show Last 20 Lines

Avoid unneeded check in vmspace_alloc().ClosedPublicActions