Plug kevent memory disclosure leaks.
ClosedPublic
Actions

Authored by markj on Nov 23 2018, 9:58 PM.

Details

Reviewers

kib
jmg

Commits

rS340899: Plug some kernel memory disclosures via kevent(2).

Summary

There are some places in the kernel where we register for events on
behalf of a userspace process. When the event triggers, the process
will get a full copy of the event structure.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 21184
Build 20539: arc lint + arc unit

Event Timeline

markj created this revision.Nov 23 2018, 9:58 PM

Harbormaster completed remote builds in B21182: Diff 51023.Nov 23 2018, 9:58 PM

markj added a reviewer: kib.Nov 23 2018, 10:01 PM

kib added inline comments.Nov 23 2018, 10:26 PM

sys/kern/kern_event.c
578	Isn't it enough to memset() once before the SLIST_FOREACH() loop ?

Lift memset() out of the knote_fork() loop.

Harbormaster completed remote builds in B21184: Diff 51025.Nov 23 2018, 10:30 PM

kib accepted this revision.Nov 23 2018, 10:48 PM

This revision is now accepted and ready to land.Nov 23 2018, 10:48 PM

Closed by commit rS340899: Plug some kernel memory disclosures via kevent(2). (authored by markj). · Explain WhyNov 24 2018, 5:04 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: jmg. · View Herald TranscriptNov 24 2018, 5:04 PM

Herald added a subscriber: imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_event.c

3 lines

vfs_aio.c

2 lines

Diff 51025

View Options

sys/kern/kern_event.c