Page MenuHomeFreeBSD
Differential D18287

sfxge(4): ensure EvQ poll stops when abort is requested
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:59 AM.
Tags
None
Referenced Files
F136199555: D18287.diff
Sun, Nov 16, 3:27 PM
Unknown Object (File)
Wed, Nov 12, 11:16 AM
Unknown Object (File)
Mon, Nov 10, 10:03 PM
Unknown Object (File)
Wed, Nov 5, 12:07 AM
Unknown Object (File)
Mon, Nov 3, 2:49 PM
Unknown Object (File)
Thu, Oct 23, 2:26 PM
Unknown Object (File)
Thu, Oct 23, 2:26 PM
Unknown Object (File)
Thu, Oct 23, 2:26 PM
View All 78 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS342521: MFC r341326
rS342450: MFC r341326
rS342342: MFC r341326
rS341326: sfxge(4): ensure EvQ poll stops when abort is requested
Summary

If an event handler requested an abort, only the inner loop was
guarenteed to be broken out of - the outer loop could continue
if total == batch.

Fix this by poisoning batch to ensure it is different to total.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21146
Build 20508: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:59 AM
Harbormaster completed remote builds in B21146: Diff 50887.Nov 21 2018, 11:59 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:11 AM
Closed by commit rS341326: sfxge(4): ensure EvQ poll stops when abort is requested (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 30 2018, 7:11 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
8 lines

Diff 50887

View Options

sys/dev/sfxge/common/efx_ev.c

Loading...