Page MenuHomeFreeBSD

sfxge(4): ensure EvQ poll stops when abort is requested
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 11:07 AM
Unknown Object (File)
Tue, Feb 4, 11:16 PM
Unknown Object (File)
Mon, Jan 27, 11:58 AM
Unknown Object (File)
Sat, Jan 25, 7:54 PM
Unknown Object (File)
Jan 18 2025, 5:29 PM
Unknown Object (File)
Nov 23 2024, 8:38 AM
Unknown Object (File)
Nov 23 2024, 8:36 AM
Unknown Object (File)
Oct 21 2024, 6:32 PM
Subscribers

Details

Summary

If an event handler requested an abort, only the inner loop was
guarenteed to be broken out of - the outer loop could continue
if total == batch.

Fix this by poisoning batch to ensure it is different to total.

Submitted by: Mark Spender <mspender at solarflare.com>
Sponsored by: Solarflare Communications, Inc.
MFC after: 1 week

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21146
Build 20508: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 30 2018, 7:11 AM
This revision was automatically updated to reflect the committed changes.