sfxge(4): improve robustness of MAC stats get via MCDI
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:39 AM.

Tags

None

Referenced Files

	F170885423: D18174.id50773.diff
	Mon, Sep 7, 7:39 AM

	Unknown Object (File)
	Fri, Aug 28, 8:07 PM

	Unknown Object (File)
	Sat, Aug 22, 8:18 PM

	Unknown Object (File)
	Sat, Aug 22, 5:55 PM

	Unknown Object (File)
	Sat, Aug 22, 8:25 AM

	Unknown Object (File)
	Wed, Aug 19, 4:09 PM

	Unknown Object (File)
	Wed, Aug 19, 4:03 PM

	Unknown Object (File)
	Tue, Aug 18, 8:35 PM

View All 84 Files

Subscribers

imp

Details

Reviewers

gnn
philip

Commits

rS341060: sfxge(4): improve robustness of MAC stats get via MCDI

Summary

Previously the code relied on the callers of efx_mcdi_mac_stats
to provide a DMA buffer or NULL depending on the action. Fix
this so that the DMA buffer is only passed in the request when
needed, and that an error is reported for a missing DMA buffer.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine