Page MenuHomeFreeBSD

sfxge(4): improve robustness of MAC stats get via MCDI
ClosedPublic

Authored by arybchik on Nov 21 2018, 11:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 1, 1:28 PM
Unknown Object (File)
Sat, Feb 1, 6:14 AM
Unknown Object (File)
Thu, Jan 30, 5:29 AM
Unknown Object (File)
Tue, Jan 28, 11:29 PM
Unknown Object (File)
Sun, Jan 26, 2:44 AM
Unknown Object (File)
Mon, Jan 6, 11:24 PM
Unknown Object (File)
Nov 27 2024, 5:19 PM
Unknown Object (File)
Nov 9 2024, 8:13 PM
Subscribers

Details

Summary

Previously the code relied on the callers of efx_mcdi_mac_stats
to provide a DMA buffer or NULL depending on the action. Fix
this so that the DMA buffer is only passed in the request when
needed, and that an error is reported for a missing DMA buffer.

Submitted by: Andy Moreton <amoreton at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21032
Build 20395: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2018, 2:16 PM
This revision was automatically updated to reflect the committed changes.