Page MenuHomeFreeBSD
Differential D18162

sfxge(4): refactoring eliminating code analysis warnings
ClosedPublic
Actions

Authored by arybchik on Nov 21 2018, 11:37 AM.
Tags
None
Referenced Files
F173829452: D18162.id51189.diff
Mon, Sep 28, 6:15 PM
Unknown Object (File)
Tue, Sep 22, 1:25 PM
Unknown Object (File)
Mon, Sep 21, 6:37 AM
Unknown Object (File)
Mon, Sep 7, 1:24 PM
Unknown Object (File)
Mon, Aug 31, 12:27 PM
Unknown Object (File)
Mon, Aug 31, 11:06 AM
Unknown Object (File)
Sun, Aug 30, 11:04 PM
Unknown Object (File)
Aug 29 2026, 1:17 PM
View All 96 Files
Subscribers
imp

Details

Reviewers
gnn
philip
Commits
rS341043: sfxge(4): refactoring eliminating code analysis warnings
Summary

Addresses most of the warnings reported by the sfn windows driver.

Submitted by: Richard Houldsworth <rhouldsworth at solarflare.com>
Sponsored by: Solarflare Communications, Inc.

Test Plan

amd64 tinderbox kernel builds tested
driver loaded/unloaded, interfaces up/down, traffic works fine

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 21020
Build 20383: arc lint + arc unit

Event Timeline

arybchik created this revision.Nov 21 2018, 11:37 AM
Harbormaster completed remote builds in B21020: Diff 50761.Nov 21 2018, 11:37 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2018, 1:02 PM
Closed by commit rS341043: sfxge(4): refactoring eliminating code analysis warnings (authored by arybchik). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 27 2018, 1:02 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sfxge/
common/
12 lines
10 lines
9 lines
1 line
14 lines
1 line
12 lines
17 lines
25 lines

Diff 50761

View Options

sys/dev/sfxge/common/ef10_mcdi.c

Loading...
View Options

sys/dev/sfxge/common/ef10_nvram.c

Loading...
View Options

sys/dev/sfxge/common/ef10_vpd.c

Loading...
View Options

sys/dev/sfxge/common/efx_filter.c

Loading...
View Options

sys/dev/sfxge/common/efx_mcdi.c

Loading...
View Options

sys/dev/sfxge/common/efx_phy.c

Loading...
View Options

sys/dev/sfxge/common/siena_mcdi.c

Loading...
View Options

sys/dev/sfxge/common/siena_nvram.c

Loading...
View Options

sys/dev/sfxge/common/siena_vpd.c

Loading...