Page MenuHomeFreeBSD

Fix unsynchronized updates to kn_status.
ClosedPublic

Authored by markj on Nov 20 2018, 9:33 PM.
Tags
None
Referenced Files
F142269587: D18060.diff
Sun, Jan 18, 12:23 AM
Unknown Object (File)
Wed, Jan 7, 7:43 AM
Unknown Object (File)
Dec 1 2025, 12:37 PM
Unknown Object (File)
Nov 29 2025, 9:55 PM
Unknown Object (File)
Nov 29 2025, 8:27 PM
Unknown Object (File)
Nov 28 2025, 4:38 AM
Unknown Object (File)
Nov 24 2025, 4:58 PM
Unknown Object (File)
Nov 24 2025, 10:47 AM
Subscribers

Details

Summary

kn_status is protected by the kqueue's lock, but we were updating it
without the kqueue lock held. For EVFILT_TIMER knotes, there is no
knlist lock, so the knote activation could occur during the kn_status
update following event registration. The activation should enqueue the
knote and set KN_QUEUED, but I have a test case where the KN_QUEUED flag
gets lost, leading to corruption of the queue.

Fix the problem by setting or clearing KN_DISABLED before dropping the
kqueue lock to call into the filter. KN_DISABLED is only used by the
core kevent code, so there is no side effect from setting it earlier.

Test Plan

I have a test program that can trigger the race and a resulting crash; Peter
added it to stress2.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20913
Build 20278: arc lint + arc unit