Page MenuHomeFreeBSD
Differential D18011

Add missing cases for PCIOCGETCONF32.
ClosedPublic
Actions

Authored by brooks on Nov 16 2018, 11:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 7, 12:25 AM
Unknown Object (File)
Sun, May 3, 12:27 AM
Unknown Object (File)
Fri, Apr 24, 11:08 AM
Unknown Object (File)
Apr 21 2026, 7:03 AM
Unknown Object (File)
Mar 23 2026, 1:37 AM
Unknown Object (File)
Mar 17 2026, 9:59 PM
Unknown Object (File)
Mar 12 2026, 8:15 PM
Unknown Object (File)
Mar 10 2026, 1:26 PM
View All 90 Files
Subscribers
imp

Details

Reviewers
kib
jbeich
Commits
rS340657: MFS r340643:
rS340643: MFC r340489-r340490
rS340490: Fix stray tab.
rS340489: Fix freebsd32 support for PCIOCGETCONF.
Summary

Fixes pciconf -l, hopefully also graphics/libdrm under 32-bit compat.

kib posted an identical patch in response to the report.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20846
Build 20227: arc lint + arc unit

Event Timeline

brooks created this revision.Nov 16 2018, 11:27 PM
Harbormaster completed remote builds in B20846: Diff 50507.Nov 16 2018, 11:27 PM
kib accepted this revision.Nov 16 2018, 11:36 PM
This revision is now accepted and ready to land.Nov 16 2018, 11:36 PM
jbeich accepted this revision.Nov 16 2018, 11:55 PM

I confirm, it fixes the regression. Tested inside 11.2 i386 jail:

  • devel/vulkan-tools (vulkaninfo)
  • www/firefox + MOZ_ACCELERATED=1 MOZ_WEBRENDER=1
  • multimedia/mpv + multimedia/libva-intel-driver
  • graphics/waifu2x-converter-cpp + lang/beignet
  • emulators/i386-wine-devel
Closed by commit rS340489: Fix freebsd32 support for PCIOCGETCONF. (authored by brooks). · Explain WhyNov 16 2018, 11:59 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptNov 16 2018, 11:59 PM
jbeich added inline comments.Nov 16 2018, 11:59 PM
sys/dev/pci/pci_user.c
969

Bogus indentation i.e., 1 too many leading tabs?

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
6 lines

Diff 50507

View Options

sys/dev/pci/pci_user.c

Loading...