Don't allow debuggers to modify SSTATUS, only to read it.
ClosedPublic
Actions

Authored by jhb on Oct 30 2018, 11:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 16, 2:07 PM

	Unknown Object (File)
	Fri, Oct 16, 12:43 PM

	Unknown Object (File)
	Sun, Oct 11, 1:32 PM

	Unknown Object (File)
	Fri, Sep 25, 6:35 AM

	Unknown Object (File)
	Thu, Sep 24, 10:25 PM

	Unknown Object (File)
	Thu, Sep 24, 4:39 PM

	Unknown Object (File)
	Thu, Sep 24, 1:11 PM

	Unknown Object (File)
	Thu, Sep 24, 7:26 AM

View All Files

Subscribers

imp

Details

Reviewers

br
markj

Commits

rS340027: Don't allow debuggers to modify SSTATUS, only to read it.

Test Plan

basic gdb of live processes still works. Trying to set $status in gdb doesn't now fails to do anything. (I didn't actually try it on an old kernel to see what would have happened, but I supsect it wouldn't have worked out well.)

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 20524
Build 19952: arc lint + arc unit

Event Timeline

jhb created this revision.Oct 30 2018, 11:45 PM

Harbormaster completed remote builds in B20524: Diff 49811.Oct 30 2018, 11:45 PM

markj accepted this revision.Oct 31 2018, 7:01 PM

This revision is now accepted and ready to land.Oct 31 2018, 7:01 PM

Closed by commit rS340027: Don't allow debuggers to modify SSTATUS, only to read it. (authored by jhb). · Explain WhyNov 1 2018, 10:13 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptNov 1 2018, 10:13 PM

Revision Contents
Changeset List

Path

Size

sys/

riscv/

machdep.c

1 line

Diff 49811

View Options

Don't allow debuggers to modify SSTATUS, only to read it.ClosedPublicActions