Page MenuHomeFreeBSD

security/linux-c6-pam and security/linux-c6-audit-libs: New ports
ClosedPublic

Authored by arrowd on Oct 15 2018, 8:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 2, 8:16 PM
Unknown Object (File)
Sun, Dec 1, 5:09 PM
Unknown Object (File)
Mon, Nov 25, 12:41 PM
Unknown Object (File)
Sat, Nov 23, 6:58 PM
Unknown Object (File)
Nov 22 2024, 6:54 PM
Unknown Object (File)
Nov 17 2024, 2:38 AM
Unknown Object (File)
Nov 12 2024, 8:21 PM
Unknown Object (File)
Nov 10 2024, 4:37 PM
Subscribers

Details

Summary

These libraries are required to run recent MATLAB under Linuxulator.
I haven't added pkg-plist.i386 files, as I don't have 32-bit VM by hand.

Test Plan

make install and ran MATLAB

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 20459
Build 19893: arc lint + arc unit

Event Timeline

Pinged emulation@ review this.

security/linux-c6-audit-libs/Makefile
11

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

security/linux-c6-pam/Makefile
11

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

arrowd added inline comments.
security/linux-c6-audit-libs/Makefile
11

I copied that from existing security/linux-c6-{gnutls,cyrus-sasl2}. Are these wrong too?

You need to hook the new ports into the build via security/Makefile

security/linux-c6-audit-libs/Makefile
11

Yes :)

arrowd marked 2 inline comments as done.

Address comments.

Added new ports to category Makefile.

You can create the i386 plist by using poudriere :)

poudriere jail -c -j104amd32 -ai386...

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: etc/libaudit.conf
Error: Orphaned: usr/lib/libaudit.so.1
Error: Orphaned: usr/lib/libaudit.so.1.0.0
Error: Orphaned: usr/lib/libauparse.so.0
Error: Orphaned: usr/lib/libauparse.so.0.0.0
Error: Orphaned: usr/share/man/man5/libaudit.conf.5.gz

and so on...

Please add that plist too.

This revision now requires changes to proceed.Oct 27 2018, 12:29 PM

Add pkg-plist's for i386 arch.

security/linux-c6-pam/pkg-plist.amd64
6

^ I personally don't like subs liek these, that are partial. But I think in that case we might let it go by.

Looks good to me, once you add the '\n' to the last lines of the pkg-descrs

security/linux-c6-pam/pkg-descr
7

^ add the new line chars on the last line.

This revision is now accepted and ready to land.Oct 28 2018, 9:13 PM
This revision was automatically updated to reflect the committed changes.