Page MenuHomeFreeBSD
Differential D17706

Reformat syscalls.master for better readability.
ClosedPublic
Actions

Authored by brooks on Oct 25 2018, 7:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Dec 30, 8:19 AM
Unknown Object (File)
Tue, Dec 10, 8:54 PM
Unknown Object (File)
Dec 3 2024, 9:54 AM
Unknown Object (File)
Dec 2 2024, 10:24 PM
Unknown Object (File)
Nov 9 2024, 9:29 AM
Unknown Object (File)
Oct 18 2024, 7:44 PM
Unknown Object (File)
Sep 30 2024, 1:48 PM
Unknown Object (File)
Sep 27 2024, 3:21 PM
View All 73 Files
Subscribers
None

Details

Reviewers
jhb
imp
emaste
Commits
rS339958: Reformat syscalls.master for better readability.
Summary

This takes advantage of two recents changes to makesyscalls.sh:
r328598: Permit a range of syscall numbers for UNIMPL
r339624: Remove the need for backslashes in syscalls.master

Syscall declerations are now split across multiple lines with the
syscall name and variables each on seperate lines (with an exception for
syscalls taking no arguments.)

Proposed on freebsd-arch October 9th to resounding silence.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20430
Build 19868: arc lint + arc unit

Event Timeline

brooks created this revision.Oct 25 2018, 7:25 PM
Harbormaster completed remote builds in B20429: Diff 49627.Oct 25 2018, 7:25 PM
brooks updated this revision to Diff 49628.Oct 25 2018, 7:30 PM
  • Switch to <type/flags><space>{. Was previously inconsistant.
Harbormaster completed remote builds in B20430: Diff 49628.Oct 25 2018, 7:30 PM
brooks added reviewers: jhb, imp, emaste.Oct 25 2018, 7:32 PM

This diff basically changes every non-comment line so it's best reviewed in concept only or as an applied patch.

The generated output from make sysent has no changes.

imp added a comment.Oct 30 2018, 8:36 PM

This looks sane to me. At least the few places I spot-checked did. And it passes the 'not too terrible to look at' test too, which is nice.

imp accepted this revision.Oct 30 2018, 8:36 PM
This revision is now accepted and ready to land.Oct 30 2018, 8:36 PM
Closed by commit rS339958: Reformat syscalls.master for better readability. (authored by brooks). · Explain WhyOct 31 2018, 4:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
kern/
4117 lines

Diff 49628

View Options

sys/kern/syscalls.master

Loading...