Page MenuHomeFreeBSD

poll: Unify userspace pollfd pointer name
ClosedPublic

Authored by cem on Oct 23 2018, 5:09 PM.
Tags
None
Referenced Files
F137093043: D17670.id49517.diff
Fri, Nov 21, 3:14 AM
F137092997: D17670.id49661.diff
Fri, Nov 21, 3:14 AM
F137092879: D17670.id.diff
Fri, Nov 21, 3:13 AM
F137091605: D17670.diff
Fri, Nov 21, 3:10 AM
Unknown Object (File)
Mon, Nov 3, 5:35 AM
Unknown Object (File)
Thu, Oct 30, 4:13 AM
Unknown Object (File)
Wed, Oct 29, 6:34 AM
Unknown Object (File)
Wed, Oct 29, 6:34 AM
Subscribers

Details

Summary

Some of the poll code used 'fds' and some used 'ufds' to refer to the
uap->fds userspace pointer that was passed around to subroutines. Some of
the poll code used 'fds' to refer to the kernel memory pollfd arrays, which
seemed unnecessarily confusing.

Unify on 'ufds' to refer to the userspace pollfd array.

Additionally, 'bits' is not an accurate description of the kernel pollfd
array in kern_poll, so rename that to 'kfds'. Finally, clean up some logic
with mallocarray() and nitems().

No functional change.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 20362
Build 19803: arc lint + arc unit