Page MenuHomeFreeBSD
Differential D17647

Resolve deadlock between epoch(9) and various network interface SX-locks
ClosedPublic
Actions

Authored by • hselasky on Oct 22 2018, 11:36 AM.
Tags
None
Referenced Files
F101319228: D17647.diff
Sun, Oct 27, 6:11 PM
Unknown Object (File)
Fri, Oct 18, 8:11 PM
Unknown Object (File)
Fri, Oct 18, 8:11 PM
Unknown Object (File)
Fri, Oct 18, 8:11 PM
Unknown Object (File)
Fri, Oct 18, 7:51 PM
Unknown Object (File)
Sep 27 2024, 2:35 PM
Unknown Object (File)
Sep 26 2024, 2:05 PM
Unknown Object (File)
Sep 17 2024, 7:50 PM
View All 42 Files
Subscribers
imp

Details

Reviewers
ae
Group Reviewers
network
Commits
rS339859: MFC r339588:
rS339588: Resolve deadlock between epoch(9) and various network interface
Summary

Resolve deadlock between epoch(9) and various network interface SX-locks, by not allowing to hold the epoch read lock over typical network interface driver IOCTL code paths. The remaining race for double free will be solved separately.

Not allowed behaviour for the network subsystem global epoch:
epoch_enter()
sx_xlock();
sx_xunlock();
epoch_exit();

Allowed behaviour for the network subsystems global epoch:
sx_xlock();
epoch_wait();
sx_xunlock();

MFC after: 1 week
Sponsored by: Mellanox Technologies

Test Plan
#!/usr/local/bin/bash
# Script to reproduce hang

for i in {1..255}
do
(ifconfig mce0.$i create; 
ifconfig mce0.$i inet 224.0.0.$i;
ifconfig mce0.$i destroy) &
done

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
head/
sys/
net/
17 lines

Diff 49445

View Options

head/sys/net/if.c

Loading...