ZSTDIO: Correctly initialize zstd context with provided 'level'
ClosedPublic
Actions

Authored by cem on Sep 13 2018, 4:17 AM.

Details

Reviewers

markj
vangyzen

Group Reviewers

releng

Commits

rS339497: ZSTDIO: Correctly initialize zstd context with provided 'level'

Summary

Prior to this revision, we allocated sufficient context space for 'level'
but never actually set the compress level parameter, so we would always get
the default '3'.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Sep 13 2018, 4:17 AM

Harbormaster completed remote builds in B19558: Diff 47978.Sep 13 2018, 4:17 AM

vangyzen accepted this revision.Sep 13 2018, 1:04 PM

This revision is now accepted and ready to land.Sep 13 2018, 1:04 PM

markj accepted this revision.Sep 13 2018, 3:37 PM

Request for acceptance into head during freeze

Closed by commit rS339497: ZSTDIO: Correctly initialize zstd context with provided 'level' (authored by cem). · Explain WhyOct 20 2018, 9:50 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptOct 20 2018, 9:50 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

subr_compressor.c

23 lines

Diff 49364

View Options

head/sys/kern/subr_compressor.c

	Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
	KDE4_WORKSPACE_VERSION= 4.11.21			KDE4_WORKSPACE_VERSION= 4.11.21
	KDE4_KDEPIM_VERSION?= 4.14.10			KDE4_KDEPIM_VERSION?= 4.14.10
	# Applications version for the kde4-applications.			# Applications version for the kde4-applications.
	KDE4_APPLICATIONS_BRANCH?= Attic			KDE4_APPLICATIONS_BRANCH?= Attic
	KDE4_APPLICATIONS_VERSION?= 15.04.3			KDE4_APPLICATIONS_VERSION?= 15.04.3
	KDE4_BRANCH?= stable			KDE4_BRANCH?= stable

	# Current KDE desktop.			# Current KDE desktop.
	KDE_FRAMEWORKS_VERSION?= 5.30.0			KDE_FRAMEWORKS_VERSION?= 5.31.0
	KDE_FRAMEWORKS_BRANCH?= stable			KDE_FRAMEWORKS_BRANCH?= stable

	# Current KDE applications.			# Current KDE applications.
	KDE_APPLICATIONS_VERSION?= 16.12.0			KDE_APPLICATIONS_VERSION?= 16.12.0
	KDE_APPLICATIONS_BRANCH?= stable			KDE_APPLICATIONS_BRANCH?= stable
	# Upstream moves old software to Attic/. Specify the newest applications release there.			# Upstream moves old software to Attic/. Specify the newest applications release there.
	# Only the major version is used for the comparison.			# Only the major version is used for the comparison.
	_KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3			_KDE_APPLICATIONS_ATTIC_VERSION= 15.12.3
	▲ Show 20 Lines • Show All 155 Lines • ▼ Show 20 Lines
	# Porting Aids frameworks provide code and utilities to ease the transition from			# Porting Aids frameworks provide code and utilities to ease the transition from
	# kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework,			# kdelibs 4 to KDE Frameworks 5. Code should aim to port away from this framework,
	# new projects should avoid using these libraries.			# new projects should avoid using these libraries.
	_USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross			_USE_FRAMEWORKS_PORTING=js jsembed kdelibs4support khtml mediaplayer kross

	# These are weird items: not officially released as Frameworks, but			# These are weird items: not officially released as Frameworks, but
	# required by them (and from KDE).			# required by them (and from KDE).
	# - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui			# - kirigami https://dot.kde.org/2016/03/30/kde-proudly-presents-kirigami-ui
	_USE_FRAMEWORKS_EXTRA= kirigami			_USE_FRAMEWORKS_EXTRA= kirigami kirigami2

	_USE_FRAMEWORKS_ALL= ecm \			_USE_FRAMEWORKS_ALL= ecm \
	${_USE_FRAMEWORKS_TIER1} \			${_USE_FRAMEWORKS_TIER1} \
	${_USE_FRAMEWORKS_TIER2} \			${_USE_FRAMEWORKS_TIER2} \
	${_USE_FRAMEWORKS_TIER3} \			${_USE_FRAMEWORKS_TIER3} \
	${_USE_FRAMEWORKS_TIER4} \			${_USE_FRAMEWORKS_TIER4} \
	${_USE_FRAMEWORKS_PORTING} \			${_USE_FRAMEWORKS_PORTING} \
	${_USE_FRAMEWORKS_EXTRA}			${_USE_FRAMEWORKS_EXTRA}
	▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines

	kimageformats_PORT= graphics/kf5-kimageformats			kimageformats_PORT= graphics/kf5-kimageformats
	kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so			kimageformats_PATH= ${QT_PLUGINDIR}/imageformats/kimg_xcf.so
	kimageformats_TYPE= run			kimageformats_TYPE= run

	kio_PORT= devel/kf5-kio			kio_PORT= devel/kf5-kio
	kio_LIB= libKF5KIOCore.so			kio_LIB= libKF5KIOCore.so

	kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so
	kirigami_PORT= x11-toolkits/kirigami			kirigami_PORT= x11-toolkits/kirigami
				kirigami_PATH= ${QT_QMLDIR}/org/kde/kirigami/libkirigamiplugin.so

				kirigami2_PORT= x11-toolkits/kirigami2
				kirigami2_PATH= ${QT_QMLDIR}/org/kde/kirigami.2/libkirigamiplugin.so

	kross_PORT= lang/kf5-kross			kross_PORT= lang/kf5-kross
	kross_LIB= libKF5KrossCore.so			kross_LIB= libKF5KrossCore.so

	mediaplayer_PORT= multimedia/kf5-kmediaplayer			mediaplayer_PORT= multimedia/kf5-kmediaplayer
	mediaplayer_LIB= libKF5MediaPlayer.so.5			mediaplayer_LIB= libKF5MediaPlayer.so.5

	newstuff_PORT= devel/kf5-knewstuff			newstuff_PORT= devel/kf5-knewstuff
	▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines

ZSTDIO: Correctly initialize zstd context with provided 'level'ClosedPublicActions