Page MenuHomeFreeBSD
Differential D17442

Fix egregious magic number constants
ClosedPublic
Actions

Authored by shurd on Oct 5 2018, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 2:07 PM
Unknown Object (File)
Fri, Mar 29, 8:33 AM
Unknown Object (File)
Dec 23 2023, 2:26 PM
Unknown Object (File)
Nov 26 2023, 5:01 AM
Unknown Object (File)
Nov 22 2023, 1:32 PM
Unknown Object (File)
Nov 22 2023, 11:11 AM
Unknown Object (File)
Nov 22 2023, 11:03 AM
Unknown Object (File)
Nov 14 2023, 7:51 AM
View All 27 Files
Subscribers
imp

Details

Reviewers
erj
sbruno
Commits
rS339267: Use mbuf defines to construct csum offload masks rather than literals
Summary

em and igb supported checksum offload bits were a hex constant.
Update to use lists of defined values.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

shurd created this revision.Oct 5 2018, 8:47 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 5 2018, 8:47 PM
Harbormaster completed remote builds in B20016: Diff 48811.Oct 5 2018, 8:48 PM
erj accepted this revision.Oct 5 2018, 9:08 PM

It's a reasonable change, but it's still kind of a surprise to me that em doesn't support IPv6 hardware offloads.

This revision is now accepted and ready to land.Oct 5 2018, 9:08 PM
sbruno added a comment.Oct 5 2018, 9:25 PM
In D17442#372066, @erj wrote:

It's a reasonable change, but it's still kind of a surprise to me that em doesn't support IPv6 hardware offloads.

I'm pretty sure that most of the modern hardware does, we just don't implement it. At least some of the chips did last time I looked.

sbruno accepted this revision.Oct 5 2018, 9:43 PM
Closed by commit rS339267: Use mbuf defines to construct csum offload masks rather than literals (authored by shurd). · Explain WhyOct 9 2018, 8:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
e1000/
7 lines

Diff 48949

View Options

head/sys/dev/e1000/if_em.h

Loading...