Src changes.
ClosedPublic
Actions

Authored by rigoletto on Oct 3 2018, 8:50 PM.

Details

Reviewers

tcberner
mat

Commits

rS339457: Add myself to calendar, and update mentors-mentee relationships.

Summary

src changes by the FreeBSD Committers Guide.

Thanks!

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20017
Build 19521: arc lint + arc unit

Event Timeline

rigoletto created this revision.Oct 3 2018, 8:50 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 3 2018, 8:50 PM

Harbormaster completed remote builds in B19940: Diff 48694.Oct 3 2018, 8:50 PM

tcberner added inline comments.Oct 3 2018, 9:19 PM

share/misc/committers-ports.dot
222	^ it looks like you're missing a n in the new line after the last name

Done. ^^

Harbormaster completed remote builds in B19961: Diff 48722.Oct 4 2018, 2:39 PM

I would like to see the commit message you plan to use.

Add myself.

Approved by: tcberner (mentor), mat (mentor)

Remove UTF-8 character.

Harbormaster completed remote builds in B20017: Diff 48812.Oct 5 2018, 8:52 PM

Looks good to me now.

This revision is now accepted and ready to land.Oct 5 2018, 8:54 PM

@mat

I got this message while commiting with @tcberner:

Sending share/misc/committers-ports.dot
Sending usr.bin/calendar/calendars/calendar.freebsd
Transmitting file data ..done
Committing transaction...
svn: E165001: Commit failed (details follow):
svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:

You need "Approved by: re" line in your log entry.

svn: E165001: Your commit message was left in a temporary file:
svn: E165001: '/home/rigoletto/Dev/FreeBSD/src/svn-commit.tmp'

Thanks!

The src tree is in freeze for a few more weeks, see FreeBSD 12.0 Release Process. You'll be able to commit this when the freeze is over.

In D17396#372140, @mat wrote:

The src tree is in freeze for a few more weeks, see FreeBSD 12.0 Release Process. You'll be able to commit this when the freeze is over.

Thank you @mat. I will wait. :-D

Can I go now? :-)

Make sure that it still looks fine, then yes :)

Closed by commit rS339457: Add myself to calendar, and update mentors-mentee relationships. (authored by rigoletto). · Explain WhyOct 20 2018, 5:46 PM

This revision was automatically updated to reflect the committed changes.

Thanks! :-)