Page MenuHomeFreeBSD
Differential D17396

Src changes.
ClosedPublic
Actions

Authored by rigoletto on Oct 3 2018, 8:50 PM.
Tags
None
Referenced Files
F166225543: D17396.id48812.diff
Wed, Aug 12, 11:41 AM
F166177775: D17396.diff
Wed, Aug 12, 3:56 AM
F166149284: D17396.id48694.diff
Tue, Aug 11, 11:39 PM
Unknown Object (File)
Mon, Aug 10, 8:23 PM
Unknown Object (File)
Sun, Aug 9, 4:40 PM
Unknown Object (File)
Sun, Aug 9, 10:01 AM
Unknown Object (File)
Sun, Aug 9, 9:23 AM
Unknown Object (File)
Sun, Aug 9, 9:23 AM
View All Files
Subscribers
imp

Details

Reviewers
tcberner
mat
Commits
rS339457: Add myself to calendar, and update mentors-mentee relationships.
Summary

src changes by the FreeBSD Committers Guide.

Thanks!

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rigoletto created this revision.Oct 3 2018, 8:50 PM
Herald added a subscriber: imp. · View Herald TranscriptOct 3 2018, 8:50 PM
Harbormaster completed remote builds in B19940: Diff 48694.Oct 3 2018, 8:50 PM
tcberner added inline comments.Oct 3 2018, 9:19 PM
share/misc/committers-ports.dot
222 ↗(On Diff #48694)

^ it looks like you're missing a n in the new line after the last name

rigoletto updated this revision to Diff 48722.Oct 4 2018, 2:39 PM
rigoletto marked an inline comment as done.

Done. ^^

Harbormaster completed remote builds in B19961: Diff 48722.Oct 4 2018, 2:39 PM
mat added a comment.Oct 4 2018, 3:11 PM

I would like to see the commit message you plan to use.

rigoletto added a comment.Oct 4 2018, 3:51 PM

Add myself.

Approved by: tcberner (mentor), mat (mentor)

rigoletto updated this revision to Diff 48812.Oct 5 2018, 8:52 PM

Remove UTF-8 character.

Harbormaster completed remote builds in B20017: Diff 48812.Oct 5 2018, 8:52 PM
tcberner accepted this revision.Oct 5 2018, 8:54 PM

Looks good to me now.

This revision is now accepted and ready to land.Oct 5 2018, 8:54 PM
rigoletto added a comment.EditedOct 5 2018, 9:06 PM

@mat

I got this message while commiting with @tcberner:

Sending share/misc/committers-ports.dot
Sending usr.bin/calendar/calendars/calendar.freebsd
Transmitting file data ..done
Committing transaction...
svn: E165001: Commit failed (details follow):
svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output:

  • You need "Approved by: re" line in your log entry.

svn: E165001: Your commit message was left in a temporary file:
svn: E165001: '/home/rigoletto/Dev/FreeBSD/src/svn-commit.tmp'

Thanks!

mat added a comment.Oct 6 2018, 8:09 AM

The src tree is in freeze for a few more weeks, see FreeBSD 12.0 Release Process. You'll be able to commit this when the freeze is over.

rigoletto added a comment.Oct 6 2018, 8:33 AM
In D17396#372140, @mat wrote:

The src tree is in freeze for a few more weeks, see FreeBSD 12.0 Release Process. You'll be able to commit this when the freeze is over.

Thank you @mat. I will wait. :-D

rigoletto added a comment.Oct 20 2018, 5:18 PM

Can I go now? :-)

tcberner added a comment.Oct 20 2018, 5:25 PM

Make sure that it still looks fine, then yes :)

Closed by commit rS339457: Add myself to calendar, and update mentors-mentee relationships. (authored by rigoletto). · Explain WhyOct 20 2018, 5:46 PM
This revision was automatically updated to reflect the committed changes.
rigoletto added a comment.Oct 20 2018, 5:47 PM

Thanks! :-)

Revision Contents
Changeset List

PathSize
head/
share/
misc/
3 lines
usr.bin/
calendar/
calendars/
1 line

Diff 49338

View Options

head/share/misc/committers-ports.dot

Loading...
View Options

head/usr.bin/calendar/calendars/calendar.freebsd

Loading...