Fix egregious magic number constants
ClosedPublic
Actions

Authored by shurd on Oct 5 2018, 8:47 PM.

Details

Reviewers

erj
sbruno

Commits

Summary

em and igb supported checksum offload bits were a hex constant.
Update to use lists of defined values.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 20016
Build 19520: arc lint + arc unit

It's a reasonable change, but it's still kind of a surprise to me that em doesn't support IPv6 hardware offloads.

This revision is now accepted and ready to land.Oct 5 2018, 9:08 PM

In D17442#372066, @erj wrote:

It's a reasonable change, but it's still kind of a surprise to me that em doesn't support IPv6 hardware offloads.

I'm pretty sure that most of the modern hardware does, we just don't implement it. At least some of the chips did last time I looked.

This revision was automatically updated to reflect the committed changes.

Path

Size

sys/

dev/

e1000/

7 lines