Page MenuHomeFreeBSD
Differential D2311

crunchide: Remove unused i386 a.out support
ClosedPublic
Actions

Authored by emaste on Apr 17 2015, 1:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 30, 1:38 PM
Unknown Object (File)
Wed, Sep 30, 1:27 PM
Unknown Object (File)
Wed, Sep 30, 3:45 AM
Unknown Object (File)
Sun, Sep 20, 4:53 AM
Unknown Object (File)
Sat, Sep 19, 10:15 AM
Unknown Object (File)
Sep 4 2026, 8:37 AM
Unknown Object (File)
Aug 25 2026, 3:51 PM
Unknown Object (File)
Aug 25 2026, 2:51 AM
View All Files
Subscribers
None

Details

Reviewers
jhb
imp
Commits
rS281655: crunchide: remove unused a.out and non-functional ECOFF support
Summary

We haven't needed a.out support in crunch for years.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste updated this revision to Diff 4872.Apr 17 2015, 1:09 PM
emaste retitled this revision from to crunchide: Remove unused i386 a.out support.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added reviewers: imp, jhb.
emaste added inline comments.Apr 17 2015, 1:16 PM
usr.sbin/crunch/crunchide/crunchide.c
215–217 ↗(On Diff #4872)

I'll remove this too

usr.sbin/crunch/crunchide/extern.h
34–37 ↗(On Diff #4872)

I'll remove this too

emaste added a comment.Apr 17 2015, 1:18 PM

This was prompted by D2305

imp accepted this revision.Apr 17 2015, 1:56 PM
imp edited edge metadata.

With or without the ECOFF removal, I'm good.

usr.sbin/crunch/crunchide/crunchide.c
215–217 ↗(On Diff #4872)

ECOFF is enough different from ELF, I'd be highly surprised if this actually worked anyway.

usr.sbin/crunch/crunchide/extern.h
34–37 ↗(On Diff #4872)

notice that these routines aren't called, since in the other file they call _elf versions.

This revision is now accepted and ready to land.Apr 17 2015, 1:56 PM
emaste closed this revision.Apr 17 2015, 3:19 PM
emaste updated this revision to Diff 4876.

Closed by commit rS281655 (authored by @emaste).

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
crunch/
crunchide/
5 lines
6 lines
198 lines
8 lines

Diff 4876

View Options

head/usr.sbin/crunch/crunchide/Makefile

Loading...
View Options

head/usr.sbin/crunch/crunchide/crunchide.c

Loading...
View Options

head/usr.sbin/crunch/crunchide/exec_aout.c

Loading...
View Options

head/usr.sbin/crunch/crunchide/extern.h

Loading...