In D2063#4, @marcel wrote:

It looks like line 501 should be removed.
My suggestion is to avoid the "uptime_seconds" key and instead just use "uptime" if that's possible.
I find it less ugly (but that's in the eye of the beholder, so feel free to stick with what you like).

Other than that: ok.

If i use 'uptime' for the tp.tv_sec then what should I call the key that contains the 'human readable' version?

I'm sorry; I missed the other use of that key.

I can make two suggestions along the lines of the first, but again it's all in the eye of the beholder, so feel free to do what you like:

1. Avoid underscores and use dashes/hyphens instead: Thus, the key becomes "uptime-seconds" (*)
2. (alternatively) Use "uptime" for seconds, because that's most likely the value that machines want to work with and rename the existing "uptime" to "uptime-human", "uptime-friendly", "uptime-clock", or anything along those lines.

(*) I think it's good to develop a style guide for this, possibly with a checker. I'll look around on the net if there's already something like a JSON naming best practices or so.

In D2063#8, @marcel wrote:

I'm sorry; I missed the other use of that key.

I can make two suggestions along the lines of the first, but again it's all in the eye of the beholder, so feel free to do what you like:

1. Avoid underscores and use dashes/hyphens instead: Thus, the key becomes "uptime-seconds" (*)
2. (alternatively) Use "uptime" for seconds, because that's most likely the value that machines want to work with and rename the existing "uptime" to "uptime-human", "uptime-friendly", "uptime-clock", or anything along those lines.

(*) I think it's good to develop a style guide for this, possibly with a checker. I'll look around on the net if there's already something like a JSON naming best practices or so.

I prefer underscores, as they are more usable for shell scripts, which do not allow - in variable names.
However, if there is a strong style guide that recommends against _, I suppose we can do that

the JSON specification says nothing

Google's JSON API guide says:

• The first character must be a letter, an underscore (_) or a dollar sign ($).
• Subsequent characters can be a letter, a digit, an underscore, or a dollar sign.

but it also calls for using camelCase, so..

I'd prefer if you would make the changes.

Thanks.

I need approval to commit this, as I am only a doc committer