netdump: Zone mbufs should be allocated before dump
ClosedPublic
Actions

Authored by cem on Sep 24 2018, 11:24 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 27, 6:41 PM

	Unknown Object (File)
	Tue, Nov 25, 2:29 PM

	Unknown Object (File)
	Mon, Nov 24, 4:21 PM

	Unknown Object (File)
	Sat, Nov 22, 10:05 AM

	Unknown Object (File)
	Fri, Nov 21, 3:56 AM

	Unknown Object (File)
	Thu, Nov 20, 9:16 PM

	Unknown Object (File)
	Thu, Nov 20, 8:26 PM

	Unknown Object (File)
	Wed, Nov 19, 2:09 PM

View All Files

Subscribers

imp

Details

Reviewers

markj

Commits

rS339501: netdump: Zone mbufs should be allocated before dump

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19785
Build 19336: arc lint + arc unit

Event Timeline

cem created this revision.Sep 24 2018, 11:24 PM

Harbormaster completed remote builds in B19785: Diff 48413.Sep 24 2018, 11:24 PM

markj added inline comments.Sep 25 2018, 1:27 AM

sys/kern/kern_mbuf.c
412	I'd add a comment or a KASSERT message to the effect of "ran out of pre-allocated buffers".
447	We want a similar assertion here.

Use a more descriptive kassert, and also check dumping in a spot I missed :-)

Harbormaster completed remote builds in B19790: Diff 48421.Sep 25 2018, 2:39 AM

markj accepted this revision.Sep 25 2018, 3:38 PM

This revision is now accepted and ready to land.Sep 25 2018, 3:38 PM

Closed by commit rS339501: netdump: Zone mbufs should be allocated before dump (authored by cem). · Explain WhyOct 20 2018, 10:25 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptOct 20 2018, 10:25 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_mbuf.c

4 lines

Diff 48413

View Options

netdump: Zone mbufs should be allocated before dumpClosedPublicActions