netdump: Zone mbufs should be allocated before dump
ClosedPublic
Actions

Authored by cem on Sep 24 2018, 11:24 PM.

Tags

None

Referenced Files

	F108040800: D17306.id48413.diff
	Mon, Jan 20, 8:04 PM

	Unknown Object (File)
	Sat, Jan 18, 9:45 PM

	Unknown Object (File)
	Sat, Jan 18, 5:08 PM

	Unknown Object (File)
	Fri, Jan 17, 3:54 PM

	Unknown Object (File)
	Dec 11 2024, 11:50 AM

	Unknown Object (File)
	Oct 18 2024, 8:04 PM

	Unknown Object (File)
	Oct 1 2024, 4:39 AM

	Unknown Object (File)
	Sep 26 2024, 3:27 AM

View All 40 Files

Subscribers

imp

Details

Reviewers

markj

Commits

rS339501: netdump: Zone mbufs should be allocated before dump

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19785
Build 19336: arc lint + arc unit

Event Timeline

cem created this revision.Sep 24 2018, 11:24 PM

Harbormaster completed remote builds in B19785: Diff 48413.Sep 24 2018, 11:24 PM

markj added inline comments.Sep 25 2018, 1:27 AM

sys/kern/kern_mbuf.c
412	I'd add a comment or a KASSERT message to the effect of "ran out of pre-allocated buffers".
447	We want a similar assertion here.

Use a more descriptive kassert, and also check dumping in a spot I missed :-)

Harbormaster completed remote builds in B19790: Diff 48421.Sep 25 2018, 2:39 AM

markj accepted this revision.Sep 25 2018, 3:38 PM

This revision is now accepted and ready to land.Sep 25 2018, 3:38 PM

Closed by commit rS339501: netdump: Zone mbufs should be allocated before dump (authored by cem). · Explain WhyOct 20 2018, 10:25 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptOct 20 2018, 10:25 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_mbuf.c

4 lines

Diff 48413

View Options

netdump: Zone mbufs should be allocated before dumpClosedPublicActions