Page MenuHomeFreeBSD
Differential D17306

netdump: Zone mbufs should be allocated before dump
ClosedPublic
Actions

Authored by cem on Sep 24 2018, 11:24 PM.
Tags
None
Referenced Files
F84423428: D17306.diff
Thu, May 23, 5:02 PM
Unknown Object (File)
Dec 22 2023, 11:56 PM
Unknown Object (File)
Sep 7 2023, 4:15 PM
Unknown Object (File)
Sep 7 2023, 4:14 PM
Unknown Object (File)
Sep 7 2023, 4:12 PM
Unknown Object (File)
Sep 7 2023, 4:12 PM
Unknown Object (File)
Sep 1 2023, 11:42 PM
Unknown Object (File)
Jul 15 2023, 10:08 PM
View All 19 Files
Subscribers
imp

Details

Reviewers
markj
Commits
rS339501: netdump: Zone mbufs should be allocated before dump

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19785
Build 19336: arc lint + arc unit

Event Timeline

cem created this revision.Sep 24 2018, 11:24 PM
Harbormaster completed remote builds in B19785: Diff 48413.Sep 24 2018, 11:24 PM
markj added inline comments.Sep 25 2018, 1:27 AM
sys/kern/kern_mbuf.c
412

I'd add a comment or a KASSERT message to the effect of "ran out of pre-allocated buffers".

447

We want a similar assertion here.

cem updated this revision to Diff 48421.Sep 25 2018, 2:39 AM
cem marked 2 inline comments as done.

Use a more descriptive kassert, and also check dumping in a spot I missed :-)

Harbormaster completed remote builds in B19790: Diff 48421.Sep 25 2018, 2:39 AM
markj accepted this revision.Sep 25 2018, 3:38 PM
This revision is now accepted and ready to land.Sep 25 2018, 3:38 PM
Closed by commit rS339501: netdump: Zone mbufs should be allocated before dump (authored by cem). · Explain WhyOct 20 2018, 10:25 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptOct 20 2018, 10:25 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
4 lines

Diff 48413

View Options

sys/kern/kern_mbuf.c

Loading...