Page MenuHomeFreeBSD
Differential D17287

amd64: macroify copyinstr
AbandonedPublic
Actions

Authored by mjg on Sep 22 2018, 11:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 19, 12:40 PM
Unknown Object (File)
Tue, Apr 14, 5:53 PM
Unknown Object (File)
Sat, Apr 11, 12:04 PM
Unknown Object (File)
Mon, Apr 6, 1:29 PM
Unknown Object (File)
Mar 8 2026, 9:29 PM
Unknown Object (File)
Mar 1 2026, 5:31 PM
Unknown Object (File)
Mar 1 2026, 11:54 AM
Unknown Object (File)
Mar 1 2026, 6:00 AM
View All 61 Files
Subscribers
imp

Details

Reviewers
kib

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 19752

Event Timeline

mjg created this revision.Sep 22 2018, 11:48 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 22 2018, 11:48 AM
Harbormaster completed remote builds in B19752: Diff 48351.Sep 22 2018, 11:48 AM
mjg added a child revision: D17288: amd64: depessimize copyinstr.Sep 22 2018, 11:51 AM
kib added inline comments.Sep 22 2018, 4:50 PM
sys/amd64/amd64/support.S
974

Why do you need a second copy of this prologue ?

mjg marked an inline comment as done.Sep 23 2018, 2:54 PM
mjg added inline comments.
sys/amd64/amd64/support.S
974

I would have to add a special case to the macro so that one primitive gets a label this can jump to. i can do that, but I think it would be uglier. Later I want to move all fault handling to the end of the file.

mjg abandoned this revision.Sep 27 2018, 3:54 PM

went in as part of r338970

Revision Contents
Changeset List

PathSize
sys/
amd64/
amd64/
73 lines

Diff 48351

View Options

sys/amd64/amd64/support.S

Loading...